This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.25-434-g990c32b
- From: fw at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 9 Jun 2017 12:09:10 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.25-434-g990c32b
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 990c32b93a29d8b8d599e10ebca19a260f84cbba (commit)
via 48bd8cda09535e2344a7969755d3fd87013f8f9f (commit)
from 6c85cc2852367ea2db91ff6a1fc0f6fc0653788d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=990c32b93a29d8b8d599e10ebca19a260f84cbba
commit 990c32b93a29d8b8d599e10ebca19a260f84cbba
Author: Florian Weimer <fweimer@redhat.com>
Date: Fri Jun 9 14:08:57 2017 +0200
malloc: Remove tst-dynarray, tst-dynarray-fail from test-srcs
They are already covered through the tests variable.
diff --git a/ChangeLog b/ChangeLog
index 0acbe88..4fef78c 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
2017-06-09 Florian Weimer <fweimer@redhat.com>
+ * malloc/Makefile (test-srcs): Remove tst-dynarray,
+ tst-dynarray-fail.
+
+2017-06-09 Florian Weimer <fweimer@redhat.com>
+
Expose TEST_VERIFY_EXIT process termination to GCC optimizers.
* support/support_test_verify_impl.c
(support_test_verify_exit_impl): Split from
diff --git a/malloc/Makefile b/malloc/Makefile
index af025cb..14c13f1 100644
--- a/malloc/Makefile
+++ b/malloc/Makefile
@@ -53,7 +53,7 @@ tests-static += tst-malloc-usable-static-tunables
endif
tests += $(tests-static)
-test-srcs = tst-mtrace tst-dynarray tst-dynarray-fail
+test-srcs = tst-mtrace
routines = malloc morecore mcheck mtrace obstack reallocarray \
scratch_buffer_grow scratch_buffer_grow_preserve \
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=48bd8cda09535e2344a7969755d3fd87013f8f9f
commit 48bd8cda09535e2344a7969755d3fd87013f8f9f
Author: Florian Weimer <fweimer@redhat.com>
Date: Fri Jun 9 14:08:13 2017 +0200
support: Expose TEST_VERIFY_EXIT behavior to GCC optimizers
Previously, the implementation would conditionally exit based on the
status argument, which GCC did not know about. This leads to
false uninitialized variable warnings when data is accessed after a
TEST_VERIFY_EXIT failure (from code which would never execute).
diff --git a/ChangeLog b/ChangeLog
index 006e7ac..0acbe88 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2017-06-09 Florian Weimer <fweimer@redhat.com>
+
+ Expose TEST_VERIFY_EXIT process termination to GCC optimizers.
+ * support/support_test_verify_impl.c
+ (support_test_verify_exit_impl): Split from
+ support_test_verify_impl.
+ * support/check.h (TEST_VERIFY): Drop status argument from
+ support_test_verify_impl call.
+ (TEST_VERIFY_EXIT): Call support_test_verify_exit_impl.
+ (support_test_verify_impl): Remove status argument.
+ (support_test_verify_exit_impl): Declare.
+
2017-06-09 Siddhesh Poyarekar <siddhesh@sourceware.org>
* sysdeps/unix/sysv/linux/aarch64/dl-procinfo.h: Remove
diff --git a/support/check.h b/support/check.h
index 1d244a3..bdcd129 100644
--- a/support/check.h
+++ b/support/check.h
@@ -51,7 +51,7 @@ __BEGIN_DECLS
if (expr) \
; \
else \
- support_test_verify_impl (-1, __FILE__, __LINE__, #expr); \
+ support_test_verify_impl (__FILE__, __LINE__, #expr); \
})
/* Record a test failure and exit if EXPR evaluates to false. */
@@ -60,7 +60,8 @@ __BEGIN_DECLS
if (expr) \
; \
else \
- support_test_verify_impl (1, __FILE__, __LINE__, #expr); \
+ support_test_verify_exit_impl \
+ (1, __FILE__, __LINE__, #expr); \
})
int support_print_failure_impl (const char *file, int line,
@@ -70,8 +71,11 @@ void support_exit_failure_impl (int exit_status,
const char *file, int line,
const char *format, ...)
__attribute__ ((noreturn, nonnull (2), format (printf, 4, 5)));
-void support_test_verify_impl (int status, const char *file, int line,
+void support_test_verify_impl (const char *file, int line,
const char *expr);
+void support_test_verify_exit_impl (int status, const char *file, int line,
+ const char *expr)
+ __attribute__ ((noreturn));
/* Record a test failure. This function returns and does not
terminate the process. The failure counter is stored in a shared
diff --git a/support/support_test_verify_impl.c b/support/support_test_verify_impl.c
index 5bae38f..55ab211 100644
--- a/support/support_test_verify_impl.c
+++ b/support/support_test_verify_impl.c
@@ -22,12 +22,16 @@
#include <stdlib.h>
void
-support_test_verify_impl (int status, const char *file, int line,
- const char *expr)
+support_test_verify_impl (const char *file, int line, const char *expr)
{
support_record_failure ();
printf ("error: %s:%d: not true: %s\n", file, line, expr);
- if (status >= 0)
- exit (status);
+}
+void
+support_test_verify_exit_impl (int status, const char *file, int line,
+ const char *expr)
+{
+ support_test_verify_impl (file, line, expr);
+ exit (status);
}
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 17 +++++++++++++++++
malloc/Makefile | 2 +-
support/check.h | 10 +++++++---
support/support_test_verify_impl.c | 12 ++++++++----
4 files changed, 33 insertions(+), 8 deletions(-)
hooks/post-receive
--
GNU C Library master sources