This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.25-334-ga7fbedf


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  a7fbedff76494b5b694f647e9c681cf8988056ce (commit)
      from  ce79740bdbccea312df6cfcf70689efb57792fc9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=a7fbedff76494b5b694f647e9c681cf8988056ce

commit a7fbedff76494b5b694f647e9c681cf8988056ce
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Thu May 18 14:02:02 2017 -0700

    Correct comments in x86_64/multiarch/memcmp.S
    
    	* sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct
    	comments.

diff --git a/ChangeLog b/ChangeLog
index 06ef578..5ebd3a0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2017-05-18  H.J. Lu  <hongjiu.lu@intel.com>
+
+	* sysdeps/x86_64/multiarch/memcmp.S (__GI_memcmp): Correct
+	comments.
+
 2017-05-18  Siddhesh Poyarekar  <siddhesh@sourceware.org>
 
 	* elf/Makefile (tst-env-setuid-ENV): Reduce value of
diff --git a/sysdeps/x86_64/multiarch/memcmp.S b/sysdeps/x86_64/multiarch/memcmp.S
index 8262317..6129820 100644
--- a/sysdeps/x86_64/multiarch/memcmp.S
+++ b/sysdeps/x86_64/multiarch/memcmp.S
@@ -56,9 +56,9 @@ END(memcmp)
 
 # ifdef SHARED
 #  undef libc_hidden_builtin_def
-/* IFUNC doesn't work with the hidden functions in shared library since
-   they will be called without setting up EBX needed for PLT which is
-   used by IFUNC.  */
+/* It doesn't make sense to send libc-internal memcmp calls through a PLT.
+   The speedup we get from using SSE4 instructions is likely eaten away
+   by the indirect call in the PLT.  */
 #  define libc_hidden_builtin_def(name) \
 	.globl __GI_memcmp; __GI_memcmp = __memcmp_sse2
 # endif

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                         |    5 +++++
 sysdeps/x86_64/multiarch/memcmp.S |    6 +++---
 2 files changed, 8 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]