This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.25-13-g5cd8188


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5cd81881e221d2943ca41b2da7bb87c0ede3386b (commit)
      from  7e1e68b45c4f2e048213cffa8ccd42a1e5c4fec6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=5cd81881e221d2943ca41b2da7bb87c0ede3386b

commit 5cd81881e221d2943ca41b2da7bb87c0ede3386b
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Feb 6 18:28:33 2017 +0000

    Eliminate libm-test.stmp.
    
    math/Makefile uses libm-test.stmp to handle dependencies involving
    multiple generated files all generated by a single sequence of
    commands in a single Makefile rule.
    
    Having separated the libm-test-ulps.h and libm-test.c generation into
    separate runs of gen-libm-test.pl, there is now no need for a single
    rule to generate multiple target files; each of the three target files
    involved can be generated by a separate Makefile rule, meaning normal
    dependencies on the individual files can be used and so libm-test.stmp
    is not needed at all.  This patch does just that, eliminating the
    .stmp file, in further preparation for when there are many separate
    libm-test-<func>.c files generated from libm-test-<func>.inc and the
    dependencies are on just the relevant .c file in each case.
    
    Tested for x86_64.
    
    	* math/Makefile (generated): Do not include libm-test.stmp.
    	($(addprefix $(objpfx), $(libm-tests-generated))): Do not depend
    	on $(objpfx)libm-test.stmp.
    	($(objpfx)libm-test.stmp): Remove rule.
    	($(objpfx)libm-test-ulps.h): New rule.
    	($(objpfx)libm-test.c): Likewise.
    	($(objpfx)libm-have-vector-test.h): Likewise.
    	($(addprefix $(objpfx), $(libm-tests.o)): Depend directly on
    	individual generated files, not libm-test.stmp.

diff --git a/ChangeLog b/ChangeLog
index d5516f0..cde75b3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,15 @@
 2017-02-06  Joseph Myers  <joseph@codesourcery.com>
 
+	* math/Makefile (generated): Do not include libm-test.stmp.
+	($(addprefix $(objpfx), $(libm-tests-generated))): Do not depend
+	on $(objpfx)libm-test.stmp.
+	($(objpfx)libm-test.stmp): Remove rule.
+	($(objpfx)libm-test-ulps.h): New rule.
+	($(objpfx)libm-test.c): Likewise.
+	($(objpfx)libm-have-vector-test.h): Likewise.
+	($(addprefix $(objpfx), $(libm-tests.o)): Depend directly on
+	individual generated files, not libm-test.stmp.
+
 	* math/gen-libm-test.pl ($output_dir): Remove variable.
 	($srcdir): Likewise.
 	($opt_a): New variable.
diff --git a/math/Makefile b/math/Makefile
index bbee8f3..b7ac897 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -208,20 +208,21 @@ libm-vec-test-wrappers = $(addsuffix -wrappers, $(libm-vec-tests))
 test-extras += $(libm-vec-test-wrappers)
 extra-test-objs += $(addsuffix .o, $(libm-vec-test-wrappers))
 libm-tests-generated = libm-test-ulps.h libm-have-vector-test.h libm-test.c
-generated += $(libm-tests-generated) libm-test.stmp
+generated += $(libm-tests-generated)
 
 ulps-file = $(firstword $(wildcard $(sysdirs:%=%/libm-test-ulps)))
 
-$(addprefix $(objpfx), $(libm-tests-generated)): $(objpfx)libm-test.stmp
+$(objpfx)libm-test-ulps.h: $(ulps-file) gen-libm-test.pl
+	$(make-target-directory)
+	$(PERL) gen-libm-test.pl -u $< -H $@
+
+$(objpfx)libm-test.c: libm-test.inc gen-libm-test.pl auto-libm-test-out
+	$(make-target-directory)
+	$(PERL) gen-libm-test.pl -c $< -a auto-libm-test-out -C $@
 
-$(objpfx)libm-test.stmp: $(ulps-file) libm-test.inc gen-libm-test.pl \
-			 gen-libm-have-vector-test.sh auto-libm-test-out
+$(objpfx)libm-have-vector-test.h: libm-test.inc gen-libm-have-vector-test.sh
 	$(make-target-directory)
-	$(PERL) gen-libm-test.pl -u $< -H "$(objpfx)libm-test-ulps.h"
-	$(PERL) gen-libm-test.pl -c libm-test.inc -a auto-libm-test-out \
-				 -C "$(objpfx)libm-test.c"
-	$(SHELL) gen-libm-have-vector-test.sh > $(objpfx)libm-have-vector-test.h
-	@echo > $@
+	$(SHELL) gen-libm-have-vector-test.sh > $@
 endif
 
 libm-test-fast-math-cflags = -fno-builtin -D__FAST_MATH__ -DTEST_FAST_MATH
@@ -337,7 +338,8 @@ $(foreach t, $(call type-foreach, $(gen-all-calls)), \
 
 ifneq (no,$(PERL))
 # This must come after the inclusion of sysdeps Makefiles via Rules.
-$(addprefix $(objpfx), $(libm-tests.o)): $(objpfx)libm-test.stmp
+$(addprefix $(objpfx), $(libm-tests.o)): $(addprefix $(objpfx),\
+						     $(libm-tests-generated))
 
 # Run the math programs to automatically generate ULPs files.
 .PHONY: regen-ulps

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog     |   10 ++++++++++
 math/Makefile |   22 ++++++++++++----------
 2 files changed, 22 insertions(+), 10 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]