This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.23-111-gf9378ac


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  f9378ac3773ffe998a2b3406568778ee9f77f759 (commit)
      from  6bc81cf205a1f4c14d5ac8e664cf1126a5d2acab (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=f9378ac3773ffe998a2b3406568778ee9f77f759

commit f9378ac3773ffe998a2b3406568778ee9f77f759
Author: Dylan Alex Simon <dylan-sourceware@dylex.net>
Date:   Tue Mar 15 13:20:01 2016 -0400

    math: don't clobber old libm.so on install [BZ #19822]
    
    When installing glibc (w/mathvec enabled) in-place on a system with
    a glibc w/out mathvec enabled, the install will clobber the existing
    libm.so (e.g., /lib64/libm-2.21.so) with a linker script.  This is
    because libm.so is a symlink to libm.so.6 which is a symlink to the
    final libm-2.21.so file.  When the makefile writes the linker script
    directly to libm.so, it gets clobbered.
    
    The simple patch below to math/Makefile fixes this.  It is based on
    the nptl Makefile, which does exactly the same thing in a safer way.

diff --git a/ChangeLog b/ChangeLog
index 6bd5a11..17c9dc0 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2016-03-21  Dylan Alex Simon  <dylan-sourceware@dylex.net>
+
+	[BZ #19822]
+	* math/Makefile ($(inst_libdir)/libm.so): Write output to $@.tmp and
+	move it to the final $@ location.
+
 2016-03-20  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
 
 	* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Fix invalid memory
diff --git a/math/Makefile b/math/Makefile
index b952124..d440833 100644
--- a/math/Makefile
+++ b/math/Makefile
@@ -100,7 +100,8 @@ $(inst_libdir)/libm.so: $(common-objpfx)format.lds \
 	 cat $<; \
 	 echo 'GROUP ( $(slibdir)/libm.so$(libm.so-version) ' \
 	      'AS_NEEDED ( $(libdir)/libmvec_nonshared.a $(slibdir)/libmvec.so$(libmvec.so-version) ) )' \
-	) > $@
+	) > $@.new
+	mv -f $@.new $@
 endif
 
 # Rules for the test suite.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog     |    6 ++++++
 math/Makefile |    3 ++-
 2 files changed, 8 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]