GNU C Library master sources branch master updated. glibc-2.23-109-g2a69f85

[azanella at sourceware dot org]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  2a69f853c03034c2e383e0f9c35b5402ce8b5473 (commit)
      from  0e8e593d7339a477ad7fdc4664d5948f824f74d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=2a69f853c03034c2e383e0f9c35b5402ce8b5473

commit 2a69f853c03034c2e383e0f9c35b5402ce8b5473
Author: Adhemerval Zanella <adhemerval.zanella@linaro.com>
Date:   Sun Mar 20 17:35:24 2016 -0300

    posix: Fix posix_spawn invalid memory access
    
    Current Linux posix_spawn spawn do not test if the pid argument is
    valid before trying to update it for success case.  This patch fixes
    it.
    
    Tested on x86_64 and i686.
    
    	* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Fix invalid memory
    	access where posix_spawn success and pid argument is null.
    	* posix/tst-spawn.c (do_test): Add posix_spawn null pid argument for
    	success case.

diff --git a/ChangeLog b/ChangeLog
index ceee215..6bd5a11 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2016-03-20  Adhemerval Zanella  <adhemerval.zanella@linaro.org>
+
+	* sysdeps/unix/sysv/linux/spawni.c (__spawnix): Fix invalid memory
+	access where posix_spawn success and pid argument is null.
+	* posix/tst-spawn.c (do_test): Add posix_spawn null pid argument for
+	success case.
+
 2016-03-20  Samuel Thibault  <samuel.thibault@ens-lyon.org>:
 
 	* sysdeps/mach/hurd/i386/c++-types.data: New file.
diff --git a/posix/tst-spawn.c b/posix/tst-spawn.c
index 68f4357..c046098 100644
--- a/posix/tst-spawn.c
+++ b/posix/tst-spawn.c
@@ -257,6 +257,10 @@ do_test (int argc, char *argv[])
    if (posix_spawn (&pid, argv[1], &actions, NULL, spargv, environ) != 0)
      error (EXIT_FAILURE, errno, "posix_spawn");
 
+   /* Same test but with a NULL pid argument.  */
+   if (posix_spawn (NULL, argv[1], &actions, NULL, spargv, environ) != 0)
+     error (EXIT_FAILURE, errno, "posix_spawn");
+
    /* Cleanup.  */
    if (posix_spawn_file_actions_destroy (&actions) != 0)
      error (EXIT_FAILURE, errno, "posix_spawn_file_actions_destroy");
diff --git a/sysdeps/unix/sysv/linux/spawni.c b/sysdeps/unix/sysv/linux/spawni.c
index 454462b..cb80cea 100644
--- a/sysdeps/unix/sysv/linux/spawni.c
+++ b/sysdeps/unix/sysv/linux/spawni.c
@@ -381,7 +381,7 @@ __spawnix (pid_t * pid, const char *file,
 
   close_not_cancel (args.pipe[0]);
 
-  if (!ec && new_pid)
+  if (!ec && pid)
     *pid = new_pid;
 
   __sigprocmask (SIG_SETMASK, &args.oldmask, 0);

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                        |    7 +++++++
 posix/tst-spawn.c                |    4 ++++
 sysdeps/unix/sysv/linux/spawni.c |    2 +-
 3 files changed, 12 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources