This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch release/2.23/master updated. glibc-2.23-9-gf23d7d2


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, release/2.23/master has been updated
       via  f23d7d2a8420a5ba2e28fc9c1d9c2b2996498d46 (commit)
      from  0a321a461c726096585c22f735266b31328232ec (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=f23d7d2a8420a5ba2e28fc9c1d9c2b2996498d46

commit f23d7d2a8420a5ba2e28fc9c1d9c2b2996498d46
Author: Hongjiu Zhang <noctuorare@gmail.com>
Date:   Sun Mar 6 20:18:21 2016 -0500

    sln: use stat64
    
    When using sln on some filesystems which return 64-bit inodes,
    the stat call might fail during install like so:
    	.../elf/sln .../elf/symlink.list
    	/lib32/libc.so.6: invalid destination: Value too large for defined data type
    	/lib32/ld-linux.so.2: invalid destination: Value too large for defined data type
    	Makefile:104: recipe for target 'install-symbolic-link' failed
    
    Switch to using stat64 all the time to avoid this.
    
    URL: https://bugs.gentoo.org/576396
    (cherry picked from commit f5e753c8c3a18a1e3c715dd11bf4dc341b5c481f)

diff --git a/ChangeLog b/ChangeLog
index 12346b3..4a27eb7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-07  Hongjiu Zhang  <noctuorare@gmail.com>
+
+	* elf/sln.c (makesymlink): Change struct stat to stat64, and lstat
+	to lstat64.
+
 2016-02-24  Marko Myllynen  <myllynen@redhat.com>
 
 	* NEWS (2.23): Fix typo in bug 19048 text.
diff --git a/elf/sln.c b/elf/sln.c
index 9d57be2..f52cb9f 100644
--- a/elf/sln.c
+++ b/elf/sln.c
@@ -164,11 +164,11 @@ makesymlinks (const char *file)
 static int
 makesymlink (const char *src, const char *dest)
 {
-  struct stat stats;
+  struct stat64 stats;
   const char *error;
 
   /* Destination must not be a directory. */
-  if (lstat (dest, &stats) == 0)
+  if (lstat64 (dest, &stats) == 0)
     {
       if (S_ISDIR (stats.st_mode))
 	{

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog |    5 +++++
 elf/sln.c |    4 ++--
 2 files changed, 7 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]