This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.21-289-gfb4041a


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  fb4041ae532fd21a82618c2be09898ea8979dec5 (commit)
      from  3f2e21e9cf577b57552f16f9ce84d0237055c7ea (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=fb4041ae532fd21a82618c2be09898ea8979dec5

commit fb4041ae532fd21a82618c2be09898ea8979dec5
Author: Mark Wielaard <mjw@redhat.com>
Date:   Tue Apr 28 13:56:15 2015 +0200

    elf.h SHF_EXCLUDE signed int 31 bit shift triggers undefined behaviour.
    
    Any use of SHF_EXCLUDE in code that tries to check it against sh_flags
    will trigger undefined behaviour because it is defined as a 31 bit shift
    against an signed integer. Fix by explicitly using an unsigned int.

diff --git a/ChangeLog b/ChangeLog
index 0e7a0a0..4b58951 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2015-04-28  Mark Wielaard  <mjw@redhat.com>
+
+	* elf/elf.h (SHF_EXCLUDE): Use unsigned 1 for shift.
+
 2015-04-27  David S. Miller  <davem@davemloft.net>
 
 	* sysdeps/unix/sysv/linux/sparc/sparc32/localplt.data: Remove
diff --git a/elf/elf.h b/elf/elf.h
index 71492a2..39bafc2 100644
--- a/elf/elf.h
+++ b/elf/elf.h
@@ -371,7 +371,7 @@ typedef struct
 #define SHF_MASKPROC	     0xf0000000	/* Processor-specific */
 #define SHF_ORDERED	     (1 << 30)	/* Special ordering requirement
 					   (Solaris).  */
-#define SHF_EXCLUDE	     (1 << 31)	/* Section is excluded unless
+#define SHF_EXCLUDE	     (1U << 31)	/* Section is excluded unless
 					   referenced or allocated (Solaris).*/
 
 /* Section group handling.  */

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog |    4 ++++
 elf/elf.h |    2 +-
 2 files changed, 5 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]