This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.21-32-ge9a5bc1


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  e9a5bc1c18b5acf3c8475e3f36431ac34bda9751 (commit)
      from  a9a002fb6cb9941ba283ef832e2a88ab00033683 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=e9a5bc1c18b5acf3c8475e3f36431ac34bda9751

commit e9a5bc1c18b5acf3c8475e3f36431ac34bda9751
Author: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date:   Sat Feb 7 22:16:19 2015 +0100

    hurd: fix sigstate locking
    
    It looks like _hurd_thread_sigstate used to return with the sigstate
    lock held long ago, but since that's no longer the case, don't unlock
    something that isn't locked.
    
    Note that it's unlikely this change fixes anything in practice since
    its current implementation (on i386) makes this call a nop.

diff --git a/ChangeLog b/ChangeLog
index 5081237..97849df 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2015-02-07  Richard Braun  <rbraun@sceen.net>
+
+	* hurd/hurd/signal.h (_hurd_critical_section_lock): Don't unlock
+	sigstate.
+
 2015-02-07  Samuel Thibault  <samuel.thibault@ens-lyon.org>
 
 	* sysdeps/pthread/aio_misc.c [!AIO_PRIO_DELTA_MAX]: Do not check
diff --git a/hurd/hurd/signal.h b/hurd/hurd/signal.h
index 4a744c1..e332242 100644
--- a/hurd/hurd/signal.h
+++ b/hurd/hurd/signal.h
@@ -175,9 +175,8 @@ _hurd_critical_section_lock (void)
       /* The thread variable is unset; this must be the first time we've
 	 asked for it.  In this case, the critical section flag cannot
 	 possible already be set.  Look up our sigstate structure the slow
-	 way; this locks the sigstate lock.  */
+	 way.  */
       ss = *location = _hurd_thread_sigstate (__mach_thread_self ());
-      __spin_unlock (&ss->lock);
     }
 
   if (! __spin_try_lock (&ss->critical_section_lock))

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog          |    5 +++++
 hurd/hurd/signal.h |    3 +--
 2 files changed, 6 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]