This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch master updated. glibc-2.20-409-g935ab81


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  935ab8179287f3b7aefdbe3829110d369be1a5c8 (commit)
      from  cc8623f196cd5d1c82573b34cb3a6a56f712790a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=935ab8179287f3b7aefdbe3829110d369be1a5c8

commit 935ab8179287f3b7aefdbe3829110d369be1a5c8
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Mon Dec 22 12:46:27 2014 +0000

    Fix resolver bind, getsockname namespace (bug 17733).
    
    On Linux architectures using socketcall, the resolver ends up bringing
    in strong symbols for bind and getsockname, which are not in
    POSIX.1-1996.  This causes linknamespace test failures:
    
    FAIL: conform/POSIX/pthread.h/linknamespace
    FAIL: conform/POSIX/sched.h/linknamespace
    FAIL: conform/POSIX/time.h/linknamespace
    
    These functions are defined as strong symbols with __bind and
    __getsockname as weak aliases.  This patch switches this to the other
    way round by removing the NO_WEAK_ALIAS definitions and so letting the
    default case in socket.S act; I see no reason for the existing
    arrangements.
    
    Tested for x86 (testsuite, and that disassembly of installed shared
    libraries is unchanged by the patch).
    
    	[BZ #17733]
    	* sysdeps/unix/sysv/linux/bind.S (NO_WEAK_ALIAS): Do not define.
    	(__bind): Do not define as weak alias.
    	* sysdeps/unix/sysv/linux/getsockname.S (NO_WEAK_ALIAS): Do not
    	define.
    	(__getsockname): Do not define as weak alias.

diff --git a/ChangeLog b/ChangeLog
index 99c248c..7279fcc 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2014-12-22  Joseph Myers  <joseph@codesourcery.com>
+
+	[BZ #17733]
+	* sysdeps/unix/sysv/linux/bind.S (NO_WEAK_ALIAS): Do not define.
+	(__bind): Do not define as weak alias.
+	* sysdeps/unix/sysv/linux/getsockname.S (NO_WEAK_ALIAS): Do not
+	define.
+	(__getsockname): Do not define as weak alias.
+
 2014-12-22  Will Newton  <will.newton@linaro.org>
 
 	* manual/install.texi: Document that we require bison 2.7
diff --git a/NEWS b/NEWS
index 6b34b13..a40deb0 100644
--- a/NEWS
+++ b/NEWS
@@ -15,7 +15,7 @@ Version 2.21
   17522, 17555, 17570, 17571, 17572, 17573, 17574, 17581, 17582, 17583,
   17584, 17585, 17589, 17594, 17601, 17608, 17616, 17625, 17630, 17633,
   17634, 17647, 17653, 17657, 17664, 17665, 17668, 17682, 17717, 17719,
-  17722, 17725.
+  17722, 17725, 17733.
 
 * CVE-2104-7817 The wordexp function could ignore the WRDE_NOCMD flag
   under certain input conditions resulting in the execution of a shell for
diff --git a/sysdeps/unix/sysv/linux/bind.S b/sysdeps/unix/sysv/linux/bind.S
index 7719ad0..61fb5eb 100644
--- a/sysdeps/unix/sysv/linux/bind.S
+++ b/sysdeps/unix/sysv/linux/bind.S
@@ -1,5 +1,3 @@
 #define	socket	bind
 #define	NARGS	3
-#define NO_WEAK_ALIAS	1
 #include <socket.S>
-weak_alias (bind, __bind)
diff --git a/sysdeps/unix/sysv/linux/getsockname.S b/sysdeps/unix/sysv/linux/getsockname.S
index 9ea371f..c138be9 100644
--- a/sysdeps/unix/sysv/linux/getsockname.S
+++ b/sysdeps/unix/sysv/linux/getsockname.S
@@ -1,5 +1,3 @@
 #define	socket	getsockname
 #define	NARGS	3
-#define NO_WEAK_ALIAS	1
 #include <socket.S>
-weak_alias (getsockname, __getsockname)

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                             |    9 +++++++++
 NEWS                                  |    2 +-
 sysdeps/unix/sysv/linux/bind.S        |    2 --
 sysdeps/unix/sysv/linux/getsockname.S |    2 --
 4 files changed, 10 insertions(+), 5 deletions(-)


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]