This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.19-491-g3dfb9a5
- From: neleai at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 27 May 2014 14:56:58 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.19-491-g3dfb9a5
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 3dfb9a5cbee3232cb38237f65759b6f230e790c0 (commit)
from 774f928582fcfefb726f115772c001043aefa01c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=3dfb9a5cbee3232cb38237f65759b6f230e790c0
commit 3dfb9a5cbee3232cb38237f65759b6f230e790c0
Author: OndÅ?ej BÃlka <neleai@seznam.cz>
Date: Tue May 27 16:56:11 2014 +0200
Remove duplicate code in elf/dl-deps.c.
diff --git a/ChangeLog b/ChangeLog
index 9d1ae9c..3ddd69b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2014-05-27 OndÅ?ej BÃlka <neleai@seznam.cz>
+
+ * elf/dl-deps.c (_dl_map_object_deps): Remove duplicate code.
+
2014-05-27 Andreas Schwab <schwab@suse.de>
* csu/libc-tls.c (__libc_setup_tls): Remove second argument from
diff --git a/elf/dl-deps.c b/elf/dl-deps.c
index 9c83c81..c3b0cfc 100644
--- a/elf/dl-deps.c
+++ b/elf/dl-deps.c
@@ -302,22 +302,24 @@ _dl_map_object_deps (struct link_map *map,
/* Store the tag in the argument structure. */
args.name = name;
- if (d->d_tag == DT_AUXILIARY)
+ /* Say that we are about to load an auxiliary library. */
+ if (__builtin_expect (GLRO(dl_debug_mask) & DL_DEBUG_LIBS,
+ 0))
+ _dl_debug_printf ("load auxiliary object=%s"
+ " requested by file=%s\n",
+ name,
+ DSO_FILENAME (l->l_name));
+
+ /* We must be prepared that the addressed shared
+ object is not available. For filter objects the dependency
+ must be available. */
+ bool malloced;
+ int err = _dl_catch_error (&objname, &errstring, &malloced,
+ openaux, &args);
+
+ if (__glibc_unlikely (errstring != NULL))
{
- /* Say that we are about to load an auxiliary library. */
- if (__builtin_expect (GLRO(dl_debug_mask) & DL_DEBUG_LIBS,
- 0))
- _dl_debug_printf ("load auxiliary object=%s"
- " requested by file=%s\n",
- name,
- DSO_FILENAME (l->l_name));
-
- /* We must be prepared that the addressed shared
- object is not available. */
- bool malloced;
- (void) _dl_catch_error (&objname, &errstring, &malloced,
- openaux, &args);
- if (__glibc_unlikely (errstring != NULL))
+ if (d->d_tag == DT_AUXILIARY)
{
/* We are not interested in the error message. */
assert (errstring != NULL);
@@ -327,23 +329,9 @@ _dl_map_object_deps (struct link_map *map,
/* Simply ignore this error and continue the work. */
continue;
}
- }
- else
- {
- /* Say that we are about to load an auxiliary library. */
- if (__builtin_expect (GLRO(dl_debug_mask) & DL_DEBUG_LIBS,
- 0))
- _dl_debug_printf ("load filtered object=%s"
- " requested by file=%s\n",
- name,
- DSO_FILENAME (l->l_name));
-
- /* For filter objects the dependency must be available. */
- bool malloced;
- int err = _dl_catch_error (&objname, &errstring, &malloced,
- openaux, &args);
- if (__glibc_unlikely (errstring != NULL))
+ else
{
+
char *new_errstring = strdupa (errstring);
objname = strdupa (objname);
if (malloced)
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 4 ++++
elf/dl-deps.c | 50 +++++++++++++++++++-------------------------------
2 files changed, 23 insertions(+), 31 deletions(-)
hooks/post-receive
--
GNU C Library master sources