This is the mail archive of the
glibc-cvs@sourceware.org
mailing list for the glibc project.
GNU C Library master sources branch master updated. glibc-2.19-154-g5896c8b
- From: vapier at sourceware dot org
- To: glibc-cvs at sourceware dot org
- Date: 13 Mar 2014 21:05:43 -0000
- Subject: GNU C Library master sources branch master updated. glibc-2.19-154-g5896c8b
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 5896c8bdd9f73cdc816a96e107ca1f7a6bc6921e (commit)
from 2d63a517e4084ec80403cd9f278690fa8b676cc4 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=5896c8bdd9f73cdc816a96e107ca1f7a6bc6921e
commit 5896c8bdd9f73cdc816a96e107ca1f7a6bc6921e
Author: Mike Frysinger <vapier@gentoo.org>
Date: Sun Dec 29 16:30:35 2013 -0500
tst-longjmp_chk2: add comments/sanity check
If the longjmp checking code is slightly broken, this code can loop
forever which isn't too helpful. Add a sanity check to keep that
from happening.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
diff --git a/ChangeLog b/ChangeLog
index e6ac778..42b2938 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2014-03-13 Mike Frysinger <vapier@gentoo.org>
+
+ * debug/tst-longjmp_chk2.c: Update header comment.
+ (stackoverflow_handler): Add comment. Call assert on pass value.
+
2014-03-13 Igor Zamyatin <igor.zamyatin@intel.com>
* config.h.in (HAVE_AVX512_SUPPORT): New #undef.
diff --git a/debug/tst-longjmp_chk2.c b/debug/tst-longjmp_chk2.c
index 22d8bf0..dae9ca0 100644
--- a/debug/tst-longjmp_chk2.c
+++ b/debug/tst-longjmp_chk2.c
@@ -1,4 +1,6 @@
-/* Test case mostly written by Paolo Bonzini <pbonzini@redhat.com>. */
+/* Verify longjmp fortify checking does not reject signal stacks.
+
+ Test case mostly written by Paolo Bonzini <pbonzini@redhat.com>. */
#include <assert.h>
#include <setjmp.h>
#include <signal.h>
@@ -18,7 +20,10 @@ static void
stackoverflow_handler (int sig)
{
stack_t altstack;
+ /* Sanity check to keep test from looping forever (in case the longjmp
+ chk code is slightly broken). */
pass++;
+ assert (pass < 5);
sigaltstack (NULL, &altstack);
/* Using printf is not really kosher in signal handlers but we know
it will work. */
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 5 +++++
debug/tst-longjmp_chk2.c | 7 ++++++-
2 files changed, 11 insertions(+), 1 deletions(-)
hooks/post-receive
--
GNU C Library master sources