This is the mail archive of the glibc-cvs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

GNU C Library master sources branch roland/libc_fatal-no-syslog created. glibc-2.17-448-g6a10554


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, roland/libc_fatal-no-syslog has been created
        at  6a105542e2f6cb62bb4cd0d9630066d5cc90a9a1 (commit)

- Log -----------------------------------------------------------------
http://sourceware.org/git/gitweb.cgi?p=glibc.git;a=commitdiff;h=6a105542e2f6cb62bb4cd0d9630066d5cc90a9a1

commit 6a105542e2f6cb62bb4cd0d9630066d5cc90a9a1
Author: Roland McGrath <roland@hack.frob.com>
Date:   Wed Mar 20 14:53:53 2013 -0700

    Never call syslog in __libc_message.

diff --git a/ChangeLog b/ChangeLog
index 9ac85ac..d77e159 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2013-03-20  Roland McGrath  <roland@hack.frob.com>
 
+	* sysdeps/posix/libc_fatal.c: Don't include <sys/syslog.h>.
+	(__libc_message): Never call vsyslog.
+
+2013-03-20  Roland McGrath  <roland@hack.frob.com>
+
 	[BZ #14812]
 	* locale/programs/localedef.c (options): Put N_ translation marker
 	on argument names, not just descriptions.
diff --git a/sysdeps/posix/libc_fatal.c b/sysdeps/posix/libc_fatal.c
index afa1b81..5071df1 100644
--- a/sysdeps/posix/libc_fatal.c
+++ b/sysdeps/posix/libc_fatal.c
@@ -29,7 +29,6 @@
 #include <sysdep.h>
 #include <unistd.h>
 #include <sys/mman.h>
-#include <sys/syslog.h>
 #include <sys/uio.h>
 #include <not-cancel.h>
 
@@ -68,11 +67,9 @@ void
 __libc_message (int do_abort, const char *fmt, ...)
 {
   va_list ap;
-  va_list ap_copy;
   int fd = -1;
 
   va_start (ap, fmt);
-  va_copy (ap_copy, ap);
 
 #ifdef FATAL_PREPARE
   FATAL_PREPARE;
@@ -170,12 +167,6 @@ __libc_message (int do_abort, const char *fmt, ...)
 
   va_end (ap);
 
-  /* If we  had no success writing the message, use syslog.  */
-  if (! written)
-    vsyslog (LOG_ERR, fmt, ap_copy);
-
-  va_end (ap_copy);
-
   if (do_abort)
     {
       BEFORE_ABORT (do_abort, written, fd);

-----------------------------------------------------------------------


hooks/post-receive
-- 
GNU C Library master sources


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]