[Bug libc/19463] linknamespace failures when compiled with -Os

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=19463

--- Comment #4 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  7fc03cf320f9ed0178babbb33de0550d393b8886 (commit)
      from  0c8a67a5737b4b6dd74bd24219fc642c8d244bee (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=7fc03cf320f9ed0178babbb33de0550d393b8886

commit 7fc03cf320f9ed0178babbb33de0550d393b8886
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Thu Feb 15 20:57:15 2018 +0000

    Fix -Os feof_unlocked linknamespace, localplt issues (bug 15105, bug
19463).

    Continuing the fixes for linknamespace and localplt test failures with
    -Os that arise from functions not being inlined in that case, this
    patch fixes such failures for feof_unlocked.

    The usual approach is followed of adding __feof_unlocked (inlined when
    feof_unlocked is), making calls use it when required for namespace
    reasons, and using libc_hidden_proto / libc_hidden_weak for the
    feof_unlocked weak alias when only localplt but not namespace issues
    are involved.  In the case of getaddrinfo.c, use of __feof_unlocked
    needs to be conditional since that code is also used in nscd (where
    __feof_unlocked is not available).

    Tested for x86_64 (both without -Os to make sure that case continues
    to work, and with -Os to make sure all the relevant linknamespace and
    localplt test failures are resolved).  Because of other such failures
    that remain after this patch, neither of the bugs can yet be closed.

        [BZ #15105]
        [BZ #19463]
        * libio/feof_u.c (feof_unlocked): Rename to __feof_unlocked and
        define as weak alias of __feof_unlocked.  Use libc_hidden_weak.
        * include/stdio.h (feof_unlocked): Use libc_hidden_proto.
        (__feof_unlocked): New declaration, and inline function if
        [__USE_EXTERN_INLINES].
        * iconv/gconv_conf.c (read_conf_file): Call __feof_unlocked
        instead of feof_unlocked.
        * intl/localealias.c [_LIBC] (FEOF): Likewise.
        * nss/nsswitch.c (nss_parse_file): Likewise.
        * sysdeps/unix/sysv/linux/readonly-area.c (__readonly_area):
        Likewise.
        * time/getdate.c (__getdate_r): Likewise.
        * sysdeps/posix/getaddrinfo.c [IS_IN (libc)] (feof_unlocked):
        Define as macro to call __feof_unlocked.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                               |   19 +++++++++++++++++++
 iconv/gconv_conf.c                      |    2 +-
 include/stdio.h                         |   10 ++++++++++
 intl/localealias.c                      |    2 +-
 libio/feof_u.c                          |    4 +++-
 nss/nsswitch.c                          |    2 +-
 sysdeps/posix/getaddrinfo.c             |    4 ++++
 sysdeps/unix/sysv/linux/readonly-area.c |    2 +-
 time/getdate.c                          |    2 +-
 9 files changed, 41 insertions(+), 6 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.