This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/21537] ../sysdeps/unix/sysv/linux/s390/s390-32/__makecontext_ret.S:44: Error: junk at end of line, first unrecognized character is `@'


https://sourceware.org/bugzilla/show_bug.cgi?id=21537

--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5e5b3b886635b52d9baa87414b97965190035e46 (commit)
      from  35810f5ccf735d8df0a783bc6ed5fbe455e64876 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5e5b3b886635b52d9baa87414b97965190035e46

commit 5e5b3b886635b52d9baa87414b97965190035e46
Author: Stefan Liebler <stli@linux.vnet.ibm.com>
Date:   Mon Jun 19 11:06:49 2017 +0200

    S390: Fix build with gcc configured with --enable-default-pie. [BZ #21537]

    Building glibc with gcc configured with --enable-default-pie failed on s390
    due to assembler messages:
    ../sysdeps/unix/sysv/linux/s390/s390-32/__makecontext_ret.S:44:
    Error: junk at end of line, first unrecognized character is `@'

    HIDDEN_JUMPTARGET was expanded to exit@PLT@GOTOFF.
    If SHARED is not defined, HIDDEN_JUMPTARGET is defined to JUMPTARGET
    in sysdeps/s390/s390-32/sysdep.h.  There it expanded to exit@PLT
    in non SHARED case as PIC is defined if gcc is configured with
    --enable-default-pie. Thus I've changed the "ifdef PIC" to "ifdef SHARED"
    as we do not want PLTs in the static obj files.  I've also changed this
    in sysdeps/s390/s390-64/sysdep.h.

    I've also adjusted
sysdeps/unix/sysv/linux/s390/s390-32/__makecontext_ret.S.
    If glibc is configured with --disable-hidden-plt, then NO_HIDDEN is
defined.
    In SHARED case HIDDEN_JUMPTARGET would be expanded to exit@PLT@GOTOFF
    instead of __GI_exit@GOTOFF.
    Now we jump to:
    - __GI_exit if SHARED is defined
    - exit@PLT if SHARED and NO_HIDDEN is defined
    - exit if both are not defined.
    On s390 31bit we have to setup GOT pointer in r12 if we use a PLT stub.
    Therefore I use SYSCALL_PIC_SETUP from sysdep.h and added the missing
semicolons.

    ChangeLog:

        [BZ #21537]
        * sysdeps/s390/s390-32/sysdep.h (JUMPTARGET, SYSCALL_PIC_SETUP):
        Check SHARED instead of PIC.
        (SYSCALL_PIC_SETUP): Add missing semicolons.
        * sysdeps/s390/s390-64/sysdep.h (JUMPTARGET, SYSCALL_PIC_SETUP):
        Check SHARED instead of PIC.
        * sysdeps/unix/sysv/linux/s390/s390-32/__makecontext_ret.S
        (__makecontext_ret): Adjust code to jump to exit.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   11 +++++++
 sysdeps/s390/s390-32/sysdep.h                      |    8 ++--
 sysdeps/s390/s390-64/sysdep.h                      |    2 +-
 .../sysv/linux/s390/s390-32/__makecontext_ret.S    |   31 +++++++------------
 4 files changed, 28 insertions(+), 24 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]