This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug math/20859] [sh4] FP_ILOGB0 invalid
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sourceware dot org
- Date: Wed, 23 Nov 2016 21:24:19 +0000
- Subject: [Bug math/20859] [sh4] FP_ILOGB0 invalid
- Auto-submitted: auto-generated
- References: <bug-20859-131@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=20859
--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via c2a82dace432ef59542bcde8ead2a7050fba51c6 (commit)
from f7f7931e581271c678e0d38818c2022c2da81f8b (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c2a82dace432ef59542bcde8ead2a7050fba51c6
commit c2a82dace432ef59542bcde8ead2a7050fba51c6
Author: Joseph Myers <joseph@codesourcery.com>
Date: Wed Nov 23 21:23:12 2016 +0000
Fix SH4 FP_ILOGB0 (bug 20859).
ISO C requires that the value of FP_ILOGB0 must be INT_MIN or
-INT_MAX. In sysdeps/sh/sh4/bits/mathdef.h, it's 0x80000001; that is,
a positive unsigned value that would be -INT_MAX if converted to int,
which is not valid (there's no actual constraint on the type, but
whatever the type the integer value must be one of the two permitted,
and types other than int don't really make sense). This patch makes
the ABI-compatible change to (-0x7fffffff).
(The testcase handles positive and negative sign separately to avoid
any issues with implicit conversions that could result in e.g. INT_MIN
converted to uintmax_t wrongly passing.)
Tested (compilation only) with build-many-glibcs.py.
[BZ #20859]
* sysdeps/sh/sh4/bits/mathdef.h (FP_ILOGB0): Define to
(-0x7fffffff) instead of 0x80000001.
* math/test-fp-ilogb-constants.c: New file.
* math/Makefile (tests): Add test-fp-ilogb-constants.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 8 +++
math/Makefile | 3 +-
.../test-fp-ilogb-constants.c | 51 ++++++++-----------
sysdeps/sh/sh4/bits/mathdef.h | 2 +-
4 files changed, 33 insertions(+), 31 deletions(-)
copy stdlib/tst-quick_exit.cc => math/test-fp-ilogb-constants.c (61%)
--
You are receiving this mail because:
You are on the CC list for the bug.