This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug malloc/17730] thread-local storage is sometimes improperly free()'d after being __libc_memalign()'d


https://sourceware.org/bugzilla/show_bug.cgi?id=17730

--- Comment #10 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  a0d47f487fe250c63cc21e9608b85bc02dc2a006 (commit)
      from  4bf5f2224baa1590f92f7a26930928fe9f7e4b57 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a0d47f487fe250c63cc21e9608b85bc02dc2a006

commit a0d47f487fe250c63cc21e9608b85bc02dc2a006
Author: Stefan Liebler <stli@linux.vnet.ibm.com>
Date:   Tue Sep 6 14:44:15 2016 +0200

    S390: Support PLT and GOT references in check-localplt.

    on s390x the test elf/check-localplt is failing after recent commits:
    "elf: Do not use memalign for TCB/TLS blocks allocation [BZ #17730]"
    "elf: Avoid using memalign for TLS allocations [BZ #17730]"
    "elf: dl-minimal malloc needs to respect fundamental alignment"
    due to "Missing required PLT reference: ld.so: __libc_memalign".

    After the commits __libc_memalign is only called in elf/dl-minimal.c in
    malloc() function in ld.so and gcc -O2/-O3 leads to R_390_GLOB_DAT
    instead of R_390_JMP_SLOT. __libc_memalign is called via
    function-pointer loaded from GOT instead of calling via a plt-stub. In
    this case there is the R_390_GLOB_DAT relocation in section .rela.dyn
    instead of R_390_JMP_SLOT in .rela.plt.
    This patch marks ld.so: __libc_memalign with R_390_GLOB_DAT in
    localplt.data to allow both relocations.
    If build with -fno-optimize-sibling-calls or on s390(31bit) a
    R_390_JMP_SLOT is generated.

    ChangeLog:

        * sysdeps/unix/sysv/linux/s390/localplt.data: Mark
        ld.so: __libc_memalign with "+ RELA R_390_GLOB_DAT".

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                  |    5 +++++
 sysdeps/unix/sysv/linux/s390/localplt.data |    9 ++++++++-
 2 files changed, 13 insertions(+), 1 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]