This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug math/16399] [mips] lrint / llrint / lround / llround missing exceptions


https://sourceware.org/bugzilla/show_bug.cgi?id=16399

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  06d97e5e6100641df2c379459e41b26bb4d7648b (commit)
      from  facdd9ea29ab94aac2b188ec3cc41f8733d769e0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=06d97e5e6100641df2c379459e41b26bb4d7648b

commit 06d97e5e6100641df2c379459e41b26bb4d7648b
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Fri Oct 9 21:02:19 2015 +0000

    Fix lrint, llrint, lround, llround missing exceptions for MIPS (bug 16399).

    For 32-bit MIPS and some other systems, various of the lrint, llrint,
    lround, llround functions can be missing exceptions on overflow
    because casts do not (in current GCC) result in the proper
    exceptions.  In the MIPS case there are two problems here: MIPS I code
    generation uses an assembler macro that doesn't raise exceptions,
    while the libgcc conversions of floating-point values to long long
    also do not raise "invalid" on all overflow cases (and can raise
    spurious "inexact").

    This patch adds support in the generic code (only the functions for
    which this problem has actually been seen) for forcing the "invalid"
    exception in the problem cases, and enables that support for the
    affected MIPS cases.

    Tested for MIPS; also tested for x86_64 and x86 that installed
    stripped shared libraries are unchanged by this patch.

        [BZ #16399]
        * sysdeps/generic/fix-fp-int-convert-overflow.h: New file.
        * sysdeps/ieee754/dbl-64/s_llrint.c: Include <fenv.h>, <limits.h>
        and <fix-fp-int-convert-overflow.h>.
        (__llrint) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/ieee754/dbl-64/s_llround.c: Include <fenv.h>, <limits.h>
        and <fix-fp-int-convert-overflow.h>.
        (__llround) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/ieee754/dbl-64/s_lrint.c: Include
        <fix-fp-int-convert-overflow.h>.
        (__lrint) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/ieee754/dbl-64/s_lround.c: Include
        <fix-fp-int-convert-overflow.h>.
        (__lround) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/ieee754/flt-32/s_llrintf.c: Include <fenv.h>, <limits.h>
        and <fix-fp-int-convert-overflow.h>.
        (__llrintf) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/ieee754/flt-32/s_llroundf.c: Include <fenv.h>,
        <limits.h> and <fix-fp-int-convert-overflow.h>.
        (__llroundf) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/ieee754/flt-32/s_lrintf.c: Include <fenv.h>, <limits.h>
        and <fix-fp-int-convert-overflow.h>.
        (__lrintf) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/ieee754/flt-32/s_lroundf.c: Include <fenv.h>, <limits.h>
        and <fix-fp-int-convert-overflow.h>.
        (__lroundf) [FE_INVALID]: Force FE_INVALID exception as needed if
        FIX_DBL_LLONG_CONVERT_OVERFLOW.
        * sysdeps/mips/mips32/fpu/fix-fp-int-convert-overflow.h: New file.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   38 ++++++++++++++++++++
 NEWS                                               |   20 +++++-----
 .../generic/fix-fp-int-convert-overflow.h          |   21 ++++++-----
 sysdeps/ieee754/dbl-64/s_llrint.c                  |   15 +++++++-
 sysdeps/ieee754/dbl-64/s_llround.c                 |   15 +++++++-
 sysdeps/ieee754/dbl-64/s_lrint.c                   |    6 +++
 sysdeps/ieee754/dbl-64/s_lround.c                  |   15 +++++++-
 sysdeps/ieee754/flt-32/s_llrintf.c                 |   15 +++++++-
 sysdeps/ieee754/flt-32/s_llroundf.c                |   15 +++++++-
 sysdeps/ieee754/flt-32/s_lrintf.c                  |   15 +++++++-
 sysdeps/ieee754/flt-32/s_lroundf.c                 |   15 +++++++-
 .../mips/mips32/fpu/fix-fp-int-convert-overflow.h  |   36 ++++++++++++++++++
 12 files changed, 193 insertions(+), 33 deletions(-)
 copy benchtests/bench-util.h => sysdeps/generic/fix-fp-int-convert-overflow.h
(57%)
 create mode 100644 sysdeps/mips/mips32/fpu/fix-fp-int-convert-overflow.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]