[Bug libc/18887] memory corruption when using getmntent on blank lines

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=18887

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  b0e805fa0d6fea33745952df7b7f5442ca4c374f (commit)
      from  30da407eca459329e060d0412c3fa6710f657e83 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b0e805fa0d6fea33745952df7b7f5442ca4c374f

commit b0e805fa0d6fea33745952df7b7f5442ca4c374f
Author: Mike Frysinger <vapier@gentoo.org>
Date:   Fri Aug 28 17:08:49 2015 -0400

    getmntent: fix memory corruption w/blank lines [BZ #18887]

    The fix for BZ #17273 introduced a single byte of memory corruption when
    the line is entirely blank.  It would walk back past the start of the
    buffer if the heap happened to be 0x20 or 0x09 and then write a NUL byte.
        buffer = '\n';
        end_ptr = buffer;
        while (end_ptr[-1] == ' ' || end_ptr[-1] == '\t')
                end_ptr--;
        *end_ptr = '\0';

    Fix that and rework the tests.  Adding the testcase for BZ #17273 to the
    existing \040 parser does not really make sense as it's unrelated, and
    leads to confusing behavior: it implicitly relies on the new entry being
    longer than the previous entry (since it just rewinds the FILE*).  Split
    it out into its own dedicated testcase instead.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                                          |   10 +++++
 misc/Makefile                                      |    3 +-
 misc/mntent_r.c                                    |    4 +-
 .../tst-mntent-blank-corrupt.c                     |   43 ++++++++-----------
 .../tst-mntent-blank-passno.c                      |   40 ++++++++++--------
 misc/tst-mntent.c                                  |   20 ---------
 6 files changed, 55 insertions(+), 65 deletions(-)
 copy posix/bug-regex35.c => misc/tst-mntent-blank-corrupt.c (60%)
 copy math/tst-definitions.c => misc/tst-mntent-blank-passno.c (55%)

-- 
You are receiving this mail because:
You are on the CC list for the bug.