[Bug libc/17786] [mips] O32 st_dev has the wrong type

["joseph at codesourcery dot com" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=17786

--- Comment #3 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
On Mon, 5 Jan 2015, matthew.fortune at imgtec dot com wrote:

> https://sourceware.org/bugzilla/show_bug.cgi?id=17786
> 
> --- Comment #2 from Matthew Fortune <matthew.fortune at imgtec dot com> ---
> (In reply to joseph@codesourcery.com from comment #1)
> > The fix also wouldn't need to change the size of the structure, so passing 
> 
> I wasn't sure if changing the size of st_dev to get the right type would be a
> valid reason for using some of the st_pad1 space. I assume that is what you are
> referring to?

The padding should be freely usable to expand st_dev.  (For little-endian 
you might even be able to avoid the separate struct stat version numbers, 
though it's probably best not to do anything endian-dependent here and 
there would still be the issue that you increase the alignment 
requirement, so properly shouldn't try storing in a 64-bit field for a 
caller with an older version number that may only have provided a 32-bit 
aligned structure.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.