This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug math/17723] acos namespace
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sourceware dot org
- Date: Tue, 30 Dec 2014 17:09:45 +0000
- Subject: [Bug math/17723] acos namespace
- Auto-submitted: auto-generated
- References: <bug-17723-131 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=17723
--- Comment #3 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 0747f818110fa70323aed53fd7b50587adcbf64f (commit)
from 63180606eea012b93f0b0cdb6ec37ea8e701d729 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0747f818110fa70323aed53fd7b50587adcbf64f
commit 0747f818110fa70323aed53fd7b50587adcbf64f
Author: Joseph Myers <joseph@codesourcery.com>
Date: Tue Dec 30 17:08:09 2014 +0000
Fix libm feraiseexcept namespace (bug 17723).
Various C90 and UNIX98 libm functions call feraiseexcept, which is not
in those standards. This causes linknamespace test failures - except
on x86 / x86_64, where feraiseexcept is inline (for the relevant
constant arguments) in bits/fenv.h.
This patch fixes this by making those functions call __feraiseexcept
instead. All changes are applied to all architectures rather than
considering the possibility that some might not be needed in some
cases (e.g. x86) as it seems most maintainable to keep architectures
consistent.
Where __feraiseexcept does not exist, it is added, with feraiseexcept
made a weak alias; where it is a strong alias, it is made weak.
libm_hidden_def / libm_hidden_proto are used with __feraiseexcept
(this might in some cases improve code generation for existing calls
to __feraiseexcept in some code on some architectures). Where there
are dummy feraiseexcept macros (on architectures without
floating-point exceptions support, to avoid compile errors from
references to undefined FE_* macros), corresponding dummy
__feraiseexcept macros are added. And on x86, to ensure
__feraiseexcept calls still get inlined, the inline function in
bits/fenv.h is refactored so that most of it can be reused in an
inline __feraiseexcept in a separate include/bits/fenv.h.
Calls are changed in C90/UNIX98 functions, but generally not in
functions missing from those standards. They are also changed in
libc_fe* functions (on the basis that those might be used in any libm
function), and in feupdateenv (on the same basis - may be used, via
default libc_*, in any libm function - of course feupdateenv will need
changing to __feupdateenv in a subsequent patch to make that fully
namespace-clean).
No __feraiseexcept is added corresponding to the feraiseexcept in
powerpc bits/fenvinline.h, because that macro definition is
conditional on !defined __NO_MATH_INLINES, and glibc libm is built
with -D__NO_MATH_INLINES, so changing internal calls to use
__feraiseexcept should make no difference.
Tested for x86_64 (testsuite; the only change in disassembly of
installed shared libraries is a slight code reordering in clog10, of
no apparent significance). Also tested for MIPS, where (in the
configuration tested) it eliminates math.h linknamespace failures for
n32 and n64 (some for o32 remain because of other issues).
[BZ #17723]
* include/fenv.h (__feraiseexcept): Use libm_hidden_proto.
* math/fraiseexcpt.c (__feraiseexcept): Use libm_hidden_def.
* sysdeps/aarch64/fpu/fraiseexcpt.c (feraiseexcept): Rename to
__feraiseexcept and define as weak alias of __feraiseexcept. Use
libm_hidden_weak.
* sysdeps/arm/fraiseexcpt.c (feraiseexcept): Likewise.
* sysdeps/hppa/fpu/fraiseexcpt.c (feraiseexcept): Likewise.
* sysdeps/i386/fpu/fraiseexcpt.c (__feraiseexcept): Use
libm_hidden_def.
* sysdeps/ia64/fpu/fraiseexcpt.c (feraiseexcept): Rename to
__feraiseexcept and define as weak alias of __feraiseexcept. Use
libm_hidden_weak.
* sysdeps/m68k/coldfire/fpu/fraiseexcpt.c (feraiseexcept):
Likewise.
* sysdeps/microblaze/math_private.h (__feraiseexcept): New macro.
* sysdeps/mips/fpu/fraiseexcpt.c (feraiseexcept): Rename to
__feraiseexcept and define as weak alias of __feraiseexcept. Use
libm_hidden_weak.
* sysdeps/powerpc/fpu/fraiseexcpt.c (__feraiseexcept): Use
libm_hidden_def.
* sysdeps/powerpc/nofpu/fraiseexcpt.c (__feraiseexcept): Likewise.
* sysdeps/powerpc/powerpc32/e500/nofpu/fraiseexcpt.c
(__feraiseexcept): Likewise.
* sysdeps/s390/fpu/fraiseexcpt.c (feraiseexcept): Rename to
__feraiseexcept and define as weak alias of __feraiseexcept. Use
libm_hidden_weak.
* sysdeps/sh/sh4/fpu/fraiseexcpt.c (feraiseexcept): Likewise.
* sysdeps/sparc/fpu/fraiseexcpt.c (__feraiseexcept): Use
libm_hidden_def.
* sysdeps/tile/math_private.h (__feraiseexcept): New macro.
* sysdeps/unix/sysv/linux/alpha/fraiseexcpt.S (__feraiseexcept):
Use libm_hidden_def.
* sysdeps/x86_64/fpu/fraiseexcpt.c (__feraiseexcept): Use
libm_hidden_def.
(feraiseexcept): Define as weak not strong alias. Use
libm_hidden_weak.
* sysdeps/x86/fpu/bits/fenv.h (__feraiseexcept_invalid_divbyzero):
New inline function. Factored out of ...
(feraiseexcept): ... here. Use __feraiseexcept_invalid_divbyzero.
* sysdeps/x86/fpu/include/bits/fenv.h: New file.
* math/e_scalb.c (invalid_fn): Call __feraiseexcept instead of
feraiseexcept.
* math/w_acos.c (__acos): Likewise.
* math/w_asin.c (__asin): Likewise.
* math/w_ilogb.c (__ilogb): Likewise.
* math/w_j0.c (y0): Likewise.
* math/w_j1.c (y1): Likewise.
* math/w_jn.c (yn): Likewise.
* math/w_log.c (__log): Likewise.
* math/w_log10.c (__log10): Likewise.
* sysdeps/aarch64/fpu/feupdateenv.c (feupdateenv): Likewise.
* sysdeps/aarch64/fpu/math_private.h
(libc_feupdateenv_test_aarch64): Likewise.
* sysdeps/alpha/fpu/feupdateenv.c (__feupdateenv): Likewise.
* sysdeps/arm/fenv_private.h (libc_feupdateenv_test_vfp): Likewise.
* sysdeps/arm/feupdateenv.c (feupdateenv): Likewise.
* sysdeps/ia64/fpu/feupdateenv.c (feupdateenv): Likewise.
* sysdeps/m68k/fpu/feupdateenv.c (__feupdateenv): Likewise.
* sysdeps/mips/fpu/feupdateenv.c (feupdateenv): Likewise.
* sysdeps/powerpc/fpu/e_sqrt.c (__slow_ieee754_sqrt): Likewise.
* sysdeps/s390/fpu/feupdateenv.c (feupdateenv): Likewise.
* sysdeps/sh/sh4/fpu/feupdateenv.c (feupdateenv): Likewise.
* sysdeps/sparc/fpu/feupdateenv.c (__feupdateenv): Likewise.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 67 ++++++++++++++++++++
NEWS | 2 +-
include/fenv.h | 1 +
math/e_scalb.c | 2 +-
math/fraiseexcpt.c | 1 +
math/w_acos.c | 2 +-
math/w_asin.c | 2 +-
math/w_ilogb.c | 2 +-
math/w_j0.c | 4 +-
math/w_j1.c | 4 +-
math/w_jn.c | 4 +-
math/w_log.c | 4 +-
math/w_log10.c | 4 +-
sysdeps/aarch64/fpu/feupdateenv.c | 4 +-
sysdeps/aarch64/fpu/fraiseexcpt.c | 6 +-
sysdeps/aarch64/fpu/math_private.h | 2 +-
sysdeps/alpha/fpu/feupdateenv.c | 2 +-
sysdeps/arm/fenv_private.h | 2 +-
sysdeps/arm/feupdateenv.c | 4 +-
sysdeps/arm/fraiseexcpt.c | 6 +-
sysdeps/hppa/fpu/fraiseexcpt.c | 6 +-
sysdeps/i386/fpu/fraiseexcpt.c | 1 +
sysdeps/ia64/fpu/feupdateenv.c | 2 +-
sysdeps/ia64/fpu/fraiseexcpt.c | 6 +-
sysdeps/m68k/coldfire/fpu/fraiseexcpt.c | 6 +-
sysdeps/m68k/fpu/feupdateenv.c | 2 +-
sysdeps/microblaze/math_private.h | 1 +
sysdeps/mips/fpu/feupdateenv.c | 2 +-
sysdeps/mips/fpu/fraiseexcpt.c | 6 +-
sysdeps/powerpc/fpu/e_sqrt.c | 4 +-
sysdeps/powerpc/fpu/fraiseexcpt.c | 1 +
sysdeps/powerpc/nofpu/fraiseexcpt.c | 1 +
sysdeps/powerpc/powerpc32/e500/nofpu/fraiseexcpt.c | 1 +
sysdeps/s390/fpu/feupdateenv.c | 2 +-
sysdeps/s390/fpu/fraiseexcpt.c | 6 +-
sysdeps/sh/sh4/fpu/feupdateenv.c | 2 +-
sysdeps/sh/sh4/fpu/fraiseexcpt.c | 6 +-
sysdeps/sparc/fpu/feupdateenv.c | 2 +-
sysdeps/sparc/fpu/fraiseexcpt.c | 1 +
sysdeps/tile/math_private.h | 1 +
sysdeps/unix/sysv/linux/alpha/fraiseexcpt.S | 1 +
sysdeps/x86/fpu/bits/fenv.h | 50 ++++++++-------
.../x86/fpu/include/bits/fenv.h | 35 +++++-----
sysdeps/x86_64/fpu/fraiseexcpt.c | 5 +-
44 files changed, 186 insertions(+), 89 deletions(-)
copy math/s_cproj.c => sysdeps/x86/fpu/include/bits/fenv.h (58%)
--
You are receiving this mail because:
You are on the CC list for the bug.