[Bug libc/14132] Get rid of INTDEF/INTUSE and *_internal aliases

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=14132

--- Comment #8 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  4243cbea6d30ce32b58abd8f1103156f8df617fa (commit)
      from  2004e7fb76bd6806253436d63ab3bda7e24c9cc1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4243cbea6d30ce32b58abd8f1103156f8df617fa

commit 4243cbea6d30ce32b58abd8f1103156f8df617fa
Author: Joseph Myers <joseph@codesourcery.com>
Date:   Tue Nov 4 17:39:39 2014 +0000

    Don't use INTDEF/INTUSE with _dl_argv (bug 14132).

    Continuing the removal of the obsolete INTDEF / INTUSE mechanism, this
    patch replaces its use for _dl_argv with rtld_hidden_data_def and
    rtld_hidden_proto.  Some places in .S files that previously used
    _dl_argv_internal or INTUSE(_dl_argv) now use __GI__dl_argv directly
    (there are plenty of existing examples of such direct use of __GI_*).

    A single place in rtld.c previously used _dl_argv without INTUSE,
    apparently accidentally, while the rtld_hidden_proto mechanism avoids
    such accidential omissions.  As a consequence, this patch *does*
    change the contents of stripped ld.so.  However, the installed
    stripped shared libraries are identical to those you get if instead of
    this patch you change that single _dl_argv use to use INTUSE, without
    any other changes.

    Tested for x86_64 (testsuite as well as comparison of installed
    stripped shared libraries as described above).

        [BZ #14132]
        * sysdeps/generic/ldsodefs.h (_dl_argv): Use rtld_hidden_proto.
        [IS_IN_rtld] (_dl_argv_internal): Do not declare.
        (rtld_progname): Make macro definition unconditional.
        * elf/rtld.c (_dl_argv): Use rtld_hidden_data_def instead of
        INTDEF.
        (dlmopen_doit): Do not use INTUSE with _dl_argv.
        (dl_main): Likewise.
        * elf/dl-sysdep.c (_dl_sysdep_start): Likewise.
        * sysdeps/alpha/dl-machine.h (RTLD_START): Use __GI__dl_argv
        instead of _dl_argv_internal.
        * sysdeps/powerpc/powerpc32/dl-start.S (_dl_start_user): Use
        __GI__dl_argv instead of INTUSE(_dl_argv).
        * sysdeps/powerpc/powerpc64/dl-machine.h (RTLD_START): Use
        __GI__dl_argv instead of _dl_argv_internal.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                              |   16 ++++++++++++
 elf/dl-sysdep.c                        |    2 +-
 elf/rtld.c                             |   40 ++++++++++++++++----------------
 sysdeps/alpha/dl-machine.h             |    6 ++--
 sysdeps/generic/ldsodefs.h             |   10 +------
 sysdeps/powerpc/powerpc32/dl-start.S   |    2 +-
 sysdeps/powerpc/powerpc64/dl-machine.h |    2 +-
 7 files changed, 44 insertions(+), 34 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.