This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug libc/14138] Move some functions to syscalls.list
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sourceware dot org
- Date: Tue, 23 Sep 2014 14:14:00 +0000
- Subject: [Bug libc/14138] Move some functions to syscalls.list
- Auto-submitted: auto-generated
- References: <bug-14138-131 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=14138
--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via 68870f1253b781960da0f8bf9d8e6fbe6cf2ff3d (commit)
from ea58f202931fdf15450e54859aaea675efb93588 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=68870f1253b781960da0f8bf9d8e6fbe6cf2ff3d
commit 68870f1253b781960da0f8bf9d8e6fbe6cf2ff3d
Author: Joseph Myers <joseph@codesourcery.com>
Date: Tue Sep 23 14:12:50 2014 +0000
Move some setrlimit definitions to syscalls.list (bug 14138).
Bug 14138 is followup cleanup after removal of support for old Linux
kernel versions: moving syscalls to syscalls.list where the only
reason for using C definitions was kernel version conditionals that
are no longer present.
This patch deals with the case of setrlimit
(sysdeps/unix/sysv/linux/i386/setrlimit.c, included by various other
architectures). Where needed (where there is also a compat symbol for
setrlimit@GLIBC_2.0), new syscalls.list entries are added. Where not
needed (where there is no such compat symbol and the minimum symbol
version for libc is 2.2 or later), no such entries are added as that
in sysdeps/unix/syscalls.list will suffice. Thus arm and sh need no
such entries, while m68k and powerpc need entries only in a
subdirectory syscalls.list file rather than for all configurations
that previously used setrlimit.c.
(setrlimit@@GLIBC_2.2 and setrlimit@GLIBC_2.0 are now semantically
identical - the new symbol version was about a change of types from
signed to unsigned and the former compatibility code for dealing with
large unsigned arguments on old kernels is no longer needed or
present, having been removed with support for pre-2.4 kernels.
However, making the two versions into aliases doesn't work at present:
the case of having both default and non-default symbol versions on the
same syscalls.list line results in a compat_symbol call in code built
for static libc, which doesn't compile. I don't suppose it would be
hard to generate SHARED conditionals from make-syscalls.sh to fix
this, but in any case this patch doesn't make things any worse, as the
functions weren't aliases before the patch either.)
Tested for x86, and ran ABI tests for ARM as an example of an
architecture where the setrlimit.c file was just removed without
adding syscalls.list entries.
[BZ #14138]
* sysdeps/unix/sysv/linux/arm/setrlimit.c: Remove file.
* sysdeps/unix/sysv/linux/i386/setrlimit.c: Likewise.
* sysdeps/unix/sysv/linux/m68k/setrlimit.c: Likewise.
* sysdeps/unix/sysv/linux/powerpc/setrlimit.c: Likewise.
* sysdeps/unix/sysv/linux/s390/s390-32/setrlimit.c: Likewise.
* sysdeps/unix/sysv/linux/sh/setrlimit.c: Likewise.
* sysdeps/unix/sysv/linux/i386/syscalls.list (setrlimit): Add
syscall entry for GLIBC_2.2 symbol version.
* sysdeps/unix/sysv/linux/m68k/m680x0/syscalls.list (setrlimit):
Likewise.
* sysdeps/unix/sysv/linux/powerpc/powerpc32/syscalls.list
(setrlimit): Likewise.
* sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list (setrlimit):
Likewise.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 18 +++++++++
sysdeps/unix/sysv/linux/arm/setrlimit.c | 1 -
sysdeps/unix/sysv/linux/i386/setrlimit.c | 38 --------------------
sysdeps/unix/sysv/linux/i386/syscalls.list | 1 +
sysdeps/unix/sysv/linux/m68k/m680x0/syscalls.list | 1 +
sysdeps/unix/sysv/linux/m68k/setrlimit.c | 1 -
.../sysv/linux/powerpc/powerpc32/syscalls.list | 1 +
sysdeps/unix/sysv/linux/powerpc/setrlimit.c | 1 -
sysdeps/unix/sysv/linux/s390/s390-32/setrlimit.c | 1 -
sysdeps/unix/sysv/linux/s390/s390-32/syscalls.list | 1 +
sysdeps/unix/sysv/linux/sh/setrlimit.c | 1 -
11 files changed, 22 insertions(+), 43 deletions(-)
delete mode 100644 sysdeps/unix/sysv/linux/arm/setrlimit.c
delete mode 100644 sysdeps/unix/sysv/linux/i386/setrlimit.c
delete mode 100644 sysdeps/unix/sysv/linux/m68k/setrlimit.c
delete mode 100644 sysdeps/unix/sysv/linux/powerpc/setrlimit.c
delete mode 100644 sysdeps/unix/sysv/linux/s390/s390-32/setrlimit.c
delete mode 100644 sysdeps/unix/sysv/linux/sh/setrlimit.c
--
You are receiving this mail because:
You are on the CC list for the bug.