This is the mail archive of the
glibc-bugs@sourceware.org
mailing list for the glibc project.
[Bug math/16562] spurious overflow exception from yn
- From: "cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>
- To: glibc-bugs at sourceware dot org
- Date: Fri, 27 Jun 2014 14:53:10 +0000
- Subject: [Bug math/16562] spurious overflow exception from yn
- Auto-submitted: auto-generated
- References: <bug-16562-131 at http dot sourceware dot org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=16562
--- Comment #2 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".
The branch, master has been updated
via be25493251c014a696b62834b0e63b155d8fe353 (commit)
from b351d85aa284f81271bc93e11301e1c2466b7c82 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=be25493251c014a696b62834b0e63b155d8fe353
commit be25493251c014a696b62834b0e63b155d8fe353
Author: Joseph Myers <joseph@codesourcery.com>
Date: Fri Jun 27 14:52:13 2014 +0000
Fix yn overflow handling in non-default rounding modes (bug 16561, bug
16562).
This patch fixes bugs 16561 and 16562, bad results of yn in overflow
cases in non-default rounding modes, both because an intermediate
overflow in the recurrence does not get detected if the result is not
an infinity and because an overflowing result may occur in the wrong
sign. The fix is to set FE_TONEAREST mode internally for the parts of
the function where such overflows can occur (which includes the call
to y1 - where yn is used to compute a Bessel function of order -1,
negating the result of y1 isn't correct for overflowing results in
directed rounding modes) and then compute an overflowing value in the
original rounding mode if the to-nearest result was an infinity.
Tested x86_64 and x86 and ulps updated accordingly. Also tested for
mips64 and powerpc32 to test the ldbl-128 and ldbl-128ibm changes.
(The tests for these bugs were added in my previous y1 patch, so the
only thing this patch has to do with the testsuite is enable yn
testing in all rounding modes.)
[BZ #16561]
[BZ #16562]
* sysdeps/ieee754/dbl-64/e_jn.c: Include <float.h>.
(__ieee754_yn): Set FE_TONEAREST mode internally and then
recompute overflowing results in original rounding mode.
* sysdeps/ieee754/flt-32/e_jnf.c: Include <float.h>.
(__ieee754_ynf): Set FE_TONEAREST mode internally and then
recompute overflowing results in original rounding mode.
* sysdeps/ieee754/ldbl-128/e_jnl.c: Include <float.h>.
(__ieee754_ynl): Set FE_TONEAREST mode internally and then
recompute overflowing results in original rounding mode.
* sysdeps/ieee754/ldbl-128ibm/e_jnl.c: Include <float.h>.
(__ieee754_ynl): Set FE_TONEAREST mode internally and then
recompute overflowing results in original rounding mode.
* sysdeps/ieee754/ldbl-96/e_jnl.c: Include <float.h>.
(__ieee754_ynl): Set FE_TONEAREST mode internally and then
recompute overflowing results in original rounding mode.
* sysdeps/i386/fpu/fenv_private.h [!__SSE2_MATH__]
(libc_feholdsetround_ctx): New macro.
* math/libm-test.inc (yn_test): Use ALL_RM_TEST.
* sysdeps/i386/fpu/libm-test-ulps: Update.
* sysdeps/x86_64/fpu/libm-test-ulps : Likewise.
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 25 ++++++
NEWS | 20 +++---
math/libm-test.inc | 4 +-
sysdeps/i386/fpu/fenv_private.h | 1 +
sysdeps/i386/fpu/libm-test-ulps | 24 ++++++
sysdeps/ieee754/dbl-64/e_jn.c | 117 ++++++++++++++++-------------
sysdeps/ieee754/flt-32/e_jnf.c | 16 ++++-
sysdeps/ieee754/ldbl-128/e_jnl.c | 139 ++++++++++++++++++----------------
sysdeps/ieee754/ldbl-128ibm/e_jnl.c | 143 +++++++++++++++++++----------------
sysdeps/ieee754/ldbl-96/e_jnl.c | 137 ++++++++++++++++++---------------
sysdeps/x86_64/fpu/libm-test-ulps | 24 ++++++
11 files changed, 389 insertions(+), 261 deletions(-)
--
You are receiving this mail because:
You are on the CC list for the bug.