[Bug nscd/16791] valgrind reports uninitialised byte(s) warning in nscd

["cvs-commit at gcc dot gnu.org" <sourceware-bugzilla at sourceware dot org>]

https://sourceware.org/bugzilla/show_bug.cgi?id=16791

--- Comment #1 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  bc8f194c8c29e46e8ee4034f06e46988dfff38f7 (commit)
       via  1cdeb2372ddecac0dfe0c132a033e9590ffa07d2 (commit)
      from  16b293a7a6f65d8ff348a603d19e8fd4372fa3a9 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bc8f194c8c29e46e8ee4034f06e46988dfff38f7

commit bc8f194c8c29e46e8ee4034f06e46988dfff38f7
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Wed Apr 30 12:00:39 2014 +0530

    Initialize all of datahead structure in nscd (BZ #16791)

    The datahead structure has an unused padding field that remains
    uninitialized.  Valgrind prints out a warning for it on querying a
    netgroups entry.  This is harmless, but is a potential data leak since
    it would result in writing out an uninitialized byte to the cache
    file.  Besides, this happens only when there is a cache miss, so we're
    not adding computation to any fast path.

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=1cdeb2372ddecac0dfe0c132a033e9590ffa07d2

commit 1cdeb2372ddecac0dfe0c132a033e9590ffa07d2
Author: Siddhesh Poyarekar <siddhesh@redhat.com>
Date:   Wed Apr 30 11:57:09 2014 +0530

    Consolidate code to initialize nscd dataset header

    This patch consolidates the code to initialize the header of a dataset
    into a single set of functions (one for positive and another for
    negative datasets) primarily to reduce repetition of code.  The
    secondary reason is to simplify Patch 2/2 which fixes the problem of
    an uninitialized byte in the header by initializing an unused field in
    the structure and hence preventing a possible data leak into the cache
    file.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog            |   20 ++++++++++++++++++++
 NEWS                 |    2 +-
 nscd/aicache.c       |   27 ++++++++-------------------
 nscd/grpcache.c      |   24 ++++++++----------------
 nscd/hstcache.c      |   27 +++++++++------------------
 nscd/initgrcache.c   |   24 ++++++++----------------
 nscd/netgroupcache.c |   33 ++++++++++++---------------------
 nscd/nscd-client.h   |   42 ++++++++++++++++++++++++++++++++++++++++++
 nscd/pwdcache.c      |   24 ++++++++----------------
 nscd/servicescache.c |   24 ++++++++----------------
 10 files changed, 124 insertions(+), 123 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.