This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug ports/16169] AArch64 clone.S is missing some CFI markup


https://sourceware.org/bugzilla/show_bug.cgi?id=16169

--- Comment #5 from Ryan S. Arnold <ryan.arnold at linaro dot org> ---
(In reply to Tom Tromey from comment #4)
> (In reply to Ryan S. Arnold from comment #2)
> 
> > Shouldn't that first cfi_endproc be located before the system call?
> > 
> >         /* X0:flags, x1:newsp, x2:parenttidptr, x3:newtls, x4:childtid.  */
> >         cfi_endproc
> >         svc     0x0
> > 
> > The rest of the patch look valid/correct.
> 
> For the placement of the cfi_endproc, I followed ARM,
> since I ran across this:
> 
> https://sourceware.org/ml/libc-ports/2010-01/msg00014.html
> 
> But there doesn't seem to be any consistency, as x86-64 puts
> it before the syscall.

Yeah, I was looking at the x86_64 example as well.  PowerPC does the same as
x86.  It seems that other examples of using cfi_endproc are inclusive of the
instructions which exit the current routine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]