This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug libc/15895] New: Unclosed '{' in nscd/netgroupcache.c if HAVE_SENDFILE is defined.


http://sourceware.org/bugzilla/show_bug.cgi?id=15895

            Bug ID: 15895
           Summary: Unclosed '{' in nscd/netgroupcache.c if HAVE_SENDFILE
                    is defined.
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: libc
          Assignee: unassigned at sourceware dot org
          Reporter: brooks at gcc dot gnu.org
                CC: drepper.fsp at gmail dot com

As per OndÅej BÃlka's cppcheck results
(http://sourceware.org/ml/libc-alpha/2013-08/msg00448.html), there is an
unclosed '{' on line 594 of nscd/netgroupcache.c if HAVE_SENDFILE is defined. 
The relevant block is:

#ifdef HAVE_SENDFILE
      if (__builtin_expect (db->mmap_used, 1) && cacheable)
    {
      assert (db->wr_fd != -1);
      assert ((char *) &dataset->resp > (char *) db->data);
      assert ((char *) dataset - (char *) db->head + sizeof (*dataset)
          <= (sizeof (struct database_pers_head)
              + db->head->module * sizeof (ref_t)
              + db->head->data_size));
# ifndef __ASSUME_SENDFILE
      ssize_t written =
# endif
        sendfileall (fd, db->wr_fd,
             (char *) &dataset->resp - (char *) db->head,
             sizeof (innetgroup_response_header));
# ifndef __ASSUME_SENDFILE
      if (written == -1 && errno == ENOSYS)
        goto use_write;
# endif
    }
      else
    {
# ifndef __ASSUME_SENDFILE
    use_write:
# endif
#endif


There is no further #ifdef HAVE_SENDFILE in that file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]