This is the mail archive of the glibc-bugs@sourceware.org mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug build/14259] --localedir arg to configure is ignored


http://sourceware.org/bugzilla/show_bug.cgi?id=14259

--- Comment #5 from Carlos O'Donell <carlos_odonell at mentor dot com> 2012-06-21 14:05:12 UTC ---
(In reply to comment #3)
> Hi Carlos,
> 
> The explanation is complex due to the nature of the build infrastructure, but
> here goes:
> 
> I want to change the location of the locale-archive in the installation. By
> default it is installed as /usr/lib(64)/locale/locale-archive. I thought I
> would be able to do this with the --localedir argument to configure. But it
> turns out that doesn't work.
> 
> The locale archive is placed in LOCALEDIR/locale-archive, and LOCALEDIR is
> defined using -D in CFLAGS from a configure variable called $localedir.
> $localedir is sourced from $libc_cv_localedir in config.make.in:14
> 
> On 32-bit builds, $libc_cv_localedir is never set, hence $localedir is always
> empty and it defaults to ${libdir}/locale (from Makeconfig:222) and can't be
> changed with --localedir.
> 
> On 64-bit builds, $libc_cv_localedir is set to ${exec_dir}/lib64/locale (see
> sysdeps/gnu/configure:20) only if --prefix=/usr is specified, otherwise it is
> left empty, and $localedir again defaults to ${libdir}/locale.
> 
> The glibc build infrastructure has some special case scripting for the case
> where --prefix=/usr, which is where I decided to make the fix.
> 
> I am not an expert in locales at all, but it seems to me that something is
> broken if I can't change the location of the locale-archive with --localedir.
> 
> Does anyone own the locale code?

The development community owns the code, we all need to step up to maintain the
code. Petr Baudis is our locale expert, but that doesn't mean he owns the
locale configuration code.

Your explanation here is perfect, it's exactly the explanation I was expecting
in the *initial* submission of the ticket. You explain what you need and why,
and what's wrong with the current code.

The target milestone is already set for 2.17, we are in the 2.16 code freeze
right now. Once we are out of the code freeze we'll start looking at the 2.17
issues. Your patch is a good starting place.

Next steps:
* Wait for the 2.16 freeze to thaw.
* Work with the maintainers to get your patch checked in.

In the meantime I suggest reviewing:
http://sourceware.org/glibc/wiki/Contribution%20checklist

Note: Your patch is not legally significant since it's a simple 2 line change.
However, if you wish to continue contributing to the project we will need a
copyright assignment in place.

-- 
Configure bugmail: http://sourceware.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]