This is the mail archive of the
glibc-bugs@sources.redhat.com
mailing list for the glibc project.
[Bug libc/700] PPC64 set/swapcontext do not restore the CCR
- From: "jakub at redhat dot com" <sourceware-bugzilla at sources dot redhat dot com>
- To: glibc-bugs at sources dot redhat dot com
- Date: 7 Feb 2005 15:05:05 -0000
- Subject: [Bug libc/700] PPC64 set/swapcontext do not restore the CCR
- References: <20050131233503.700.sjmunroe@us.ibm.com>
- Reply-to: sourceware-bugzilla at sources dot redhat dot com
------- Additional Comments From jakub at redhat dot com 2005-02-07 15:05 -------
Looks good to me, except the ChangeLog entry:
1) setcontext.S contains {__novec_,__}setcontext, not *getcontext
2) updating of Copyright year does not belong to ChangeLog, unless the year
change is e.g. in the messages printed by some program or library
3) When the description is identical for multiple functions and/or files,
you should just write it for the first one and use Likewise. for the rest.
So IMHO you want something like:
2005-02-07 Steven Munroe <sjmunroe@us.ibm.com>
[BZ #700]
* sysdeps/unix/sysv/linux/powerpc/powerpc64/setcontext.S
(__novec_setcontext, __setcontext): Fix a typo so CCR is restored.
Load MSR as a doubleword.
* sysdeps/unix/sysv/linux/powerpc/powerpc64/swapcontext.S
(__novec_swapcontext, __swapcontext): Likewise.
Surely you can assign the bug to yourself, even already when you start
working on the fix to prevent others from duplicating the work.
--
http://sources.redhat.com/bugzilla/show_bug.cgi?id=700
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.