This is the mail archive of the glibc-bugs@sources.redhat.com mailing list for the glibc project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[Bug regex/506] New: there is dead code in regex


The flurry of algorithms to efficiently implement backreferences left behind
some dead code in regex.

The patch at http://sources.redhat.com/ml/libc-alpha/2004-11/msg00016.html
removes several unused parameters and struct fields.

The most egregious is the "flag" struct re_backref_cache_entry field.
Removing it turned a potentially quadratic loop into linear, though I did
not try to find a case in which this actually happened.

In another case, it looks like changing the algorithms would have required
changing the node_set passed to sift_states_bkref, but this was not done.
So this patch does that instead of only removing the unused parameter.

-- 
           Summary: there is dead code in regex
           Product: glibc
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: regex
        AssignedTo: bonzini at gnu dot org
        ReportedBy: bonzini at gnu dot org
                CC: glibc-bugs-regex at sources dot redhat dot com,glibc-
                    bugs at sources dot redhat dot com
OtherBugsDependingO 500
             nThis:


http://sources.redhat.com/bugzilla/show_bug.cgi?id=506

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]