This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 19/28] arm64/sve: ptrace and ELF coredump support
- From: Dave Martin <Dave dot Martin at arm dot com>
- To: "Okamoto, Takayuki" <tokamoto at jp dot fujitsu dot com>
- Cc: "linux-arch at vger dot kernel dot org" <linux-arch at vger dot kernel dot org>, "libc-alpha at sourceware dot org" <libc-alpha at sourceware dot org>, Ard Biesheuvel <ard dot biesheuvel at linaro dot org>, Szabolcs Nagy <szabolcs dot nagy at arm dot com>, "gdb at sourceware dot org" <gdb at sourceware dot org>, Yao Qi <Yao dot Qi at arm dot com>, Will Deacon <will dot deacon at arm dot com>, Oleg Nesterov <oleg at redhat dot com>, Alex Bennée <alex dot bennee at linaro dot org>, Richard Sandiford <richard dot sandiford at arm dot com>, Alexander Viro <viro at zeniv dot linux dot org dot uk>, Alan Hayward <alan dot hayward at arm dot com>, Catalin Marinas <catalin dot marinas at arm dot com>, "kvmarm at lists dot cs dot columbia dot edu" <kvmarm at lists dot cs dot columbia dot edu>, "linux-arm-kernel at lists dot infradead dot org" <linux-arm-kernel at lists dot infradead dot org>
- Date: Fri, 8 Sep 2017 14:11:40 +0100
- Subject: Re: [PATCH v2 19/28] arm64/sve: ptrace and ELF coredump support
- Authentication-results: sourceware.org; auth=none
- References: <1504198860-12951-1-git-send-email-Dave.Martin@arm.com> <1504198860-12951-20-git-send-email-Dave.Martin@arm.com> <5FA513F682BE7F4EAAB8EE035D5B08E44109DFE8@G01JPEXMBKW02> <20170906181634.GF6321@e103592.cambridge.arm.com> <5FA513F682BE7F4EAAB8EE035D5B08E44109EBDF@G01JPEXMBKW02>
On Thu, Sep 07, 2017 at 05:11:45AM +0000, Okamoto, Takayuki wrote:
> Hi Dave,
>
> Thank you for your reply.
>
> > Your fix looks correct and seems to work. For stylistic reasons, I may
> > write it like this instead, but the effect should be the same:
> >
> > header->max_vl = sve_max_vl;
> > if (WARN_ON(!sve_vl_valid(sve_max_vl))
> > header->max_vl = header->vl;
>
> It is better than my fix.
> Please, apply it at next version.
I've rebased to v4.13 and pushed a branch to track fixes against v2,
here:
* http://linux-arm.org/git?p=linux-dm.git;a=shortlog;h=refs/heads/sve/v2%2Bfixes
* git://linux-arm.org/linux-dm.git sve/v2+fixes
Cheers
---Dave