This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 05.09.2017 13:18, John Baldwin wrote: > On 9/5/17 4:48 AM, Kamil Rytarowski wrote: >> On 05.09.2017 04:43, John Baldwin wrote: >>> -/* Not all versions of FreeBSD/i386 that support the debug registers >>> - have this macro. */ >>> +/* Helper macro to access debug register X. FreeBSD/amd64 and modern >>> + versions of FreeBSD/i386 provide this macro in system headers. Define >>> + a local version for systems that do not provide it. */ >>> #ifndef DBREG_DRX >>> +#ifdef __NetBSD__ >>> +#define DBREG_DRX(d, x) ((d)->dr[x]) >>> +#else >>> #define DBREG_DRX(d, x) ((&d->dr0)[x]) >>> #endif >>> +#endif >>> >>> static unsigned long >>> x86bsd_dr_get (ptid_t ptid, int regnum) >>> >> >> Do we support FreeBSD releases developed in year 2002? This macro has >> point for such old systems as it keeps compat between old and new >> structure layout. > > I have been trimming some older things from GDB master such as support for bsd-uthread > and FreeBSD/alpha. However, keeping a fallback for this macro doesn't seem to be overly > onerous or inhibiting maintenance currently. > I will submit a patch to refactor it out, however in future. Right now I keep upstreaming patches to make GDB cleanly buildable. I've attached a NetBSD buildbot again: https://gdb-build.sergiodj.net/builders/NetBSD-x86_64-m64 I'm working on patches to sort out all the issues.
Attachment:
signature.asc
Description: OpenPGP digital signature
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |