This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: ChangeLogs in commit messages
- From: Doug Evans <dje at google dot com>
- To: James Hogan <james dot hogan at imgtec dot com>
- Cc: Joel Brobecker <brobecker at adacore dot com>, Gary Benson <gbenson at redhat dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>, Andreas Schwab <schwab at linux-m68k dot org>, gdb <gdb at sourceware dot org>, Andreas Arnez <arnez at linux dot vnet dot ibm dot com>
- Date: Tue, 9 Sep 2014 09:25:16 -0700
- Subject: Re: ChangeLogs in commit messages
- Authentication-results: sourceware.org; auth=none
- References: <87mwage6x2 dot fsf at redhat dot com> <871trsuz55 dot fsf at igel dot home> <20140904090616 dot GA23758 at blade dot nx> <87y4tzcvny dot fsf at redhat dot com> <CADPb22ShAUeyzwpaLnTO4+ob=S1P2PyqD=4oN94fEx4ikNKUAw at mail dot gmail dot com> <20140904173624 dot GA10113 at blade dot nx> <20140905101324 dot GA3731 at blade dot nx> <CADPb22Sk7guAz5GTAPsKnKeq8=_x=_n7ecB8kPBXVmQE2GYvaw at mail dot gmail dot com> <20140908095029 dot GA24266 at blade dot nx> <540DAA52 dot 2000103 at imgtec dot com> <20140908132414 dot GK13931 at adacore dot com> <540EBF74 dot 6040908 at imgtec dot com>
On Tue, Sep 9, 2014 at 1:51 AM, James Hogan <james.hogan@imgtec.com> wrote:
> On 08/09/14 14:24, Joel Brobecker wrote:
>>> IMHO this is a really bad idea.
>>
>> I wouldn't say "a really bad", but I tend to agree with the reasoning.
>> It's a bit unnatural to me that git would chose to show the author
>> date by default over the commit date
>
> From the patch author point of view, cleaning up a patchset by
> interactive rebasing, or rebasing to keep their branch up to date, I
> think the author date probably is more natural, and in less linear
> histories (look at Linux repo for example) I suspect the commit date
> wouldn't be as meaningful.
Authors come and go, and, for me as an author, after six months I
would certainly prefer to see in the upstream tree a date as close as
possible to when the patch was pushed upstream.
[plus the needs of the many outweigh the needs of the few ... 1/2 :-)]
> [...] It'd be nice if
> something similar was possible with git-blame.
Indeed!
> You can add new pretty formats too, e.g.
>
> [pretty]
> fullcommit = "commit %H\nAuthor: %an <%ae>\nCommitDate: %cd\n\n%B"
> [format]
> pretty=fullcommit
>
> This shows author name, but commit date, but I didn't figure out how to
> indent the body like pretty=fuller does.
Interesting, thanks!