This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: [PATCH] guile: Type-check the argument to 'history-append!'
- From: ludo at gnu dot org (Ludovic CourtÃs)
- To: Doug Evans <xdje42 at gmail dot com>
- Cc: gdb at sourceware dot org
- Date: Fri, 06 Jun 2014 00:06:07 +0200
- Subject: Re: [PATCH] guile: Type-check the argument to 'history-append!'
- Authentication-results: sourceware.org; auth=none
- References: <87vbsfv7t9 dot fsf at gnu dot org> <CAP9bCMTDLWhW-VrJ479b6-GEbifzFcmO5Oe0XhL2BmDPBHwZ=A at mail dot gmail dot com>
Doug Evans <xdje42@gmail.com> skribis:
> On Thu, Jun 5, 2014 at 5:50 AM, Ludovic CourtÃs <ludo@gnu.org> wrote:
>> The patch below add a missing type check in âhistory-append!â (Iâm guilty.)
>>
>> OK to push?
>>
>> Ludoâ.
>>
>> gdb/
>> 2014-06-05 Ludovic CourtÃs <ludo@gnu.org>
>>
>> * guile/scm-value.c (gdbscm_history_append_x): Use
>> 'vlscm_get_value_smob_arg_unsafe' instead of
>> 'vlscm_scm_to_value'.
>>
>> gdb/testsuite/
>> 2014-06-05 Ludovic CourtÃs <ludo@gnu.org>
>>
>> * gdb.guile/scm-value.exp (test_value_in_inferior): Add test
>> "history-append! type error".
>
> LGTM.
Thanks, pushed.
Ludoâ.