This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tuesday 27 November 2012 16:24:46 Joel Brobecker wrote: > > Subject: [PATCH] libiberty/md5: fix strict alias warnings > > > > Current libiberty md5 code triggers these warnings with gcc-4.7.1 for me: > > > > libiberty/md5.c: In function 'md5_finish_ctx': > > libiberty/md5.c:117:3: warning: dereferencing type-punned pointer will > > break strict-aliasing rules [-Wstrict-aliasing] > > libiberty/md5.c:118:3: warning: dereferencing type-punned pointer will > > break strict-aliasing rules [-Wstrict-aliasing] > > > > The change below fixes things for me. The optimized output (-O2) is > > the same before/after my change on x86_64-linux. I imagine it'll be > > the same for most targets. It seems simpler than using a union on the > > md5_ctx buffer since these are the only two locations in the code > > where this occurs. > > I am on the fence regarding this change. On the one hand, it seems > hardly critical, since it only fixes some warnings, and does not seem > to cause any improvement in the actual code generated. On the other > hand, this module appears to be completely unused in all of GDB (?). > So the risk would be small. For that reason, and the fact that the code > has been in since end of July, I think it's OK to include it, and > avoid the warnings. yeah, i don't think it's critical. i mentioned it because i was carrying it in Gentoo's 7.5 patchset (due to the build warnings). i also can't find any md5 usage in gdb. binutils uses it in the linker, but that seems to be all. i'll commit it to the branch. -mike
Attachment:
signature.asc
Description: This is a digitally signed message part.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |