This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: New ARI web page, generated using script inside CVS tree in gdb/contrib/ari directory
- From: Pedro Alves <palves at redhat dot com>
- To: Joel Brobecker <brobecker at adacore dot com>
- Cc: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>, gdb at sourceware dot org
- Date: Mon, 12 Nov 2012 18:17:16 +0000
- Subject: Re: New ARI web page, generated using script inside CVS tree in gdb/contrib/ari directory
- References: <002701cdc0b9$542d2560$fc877020$@muller@ics-cnrs.unistra.fr> <20121112180707.GQ4847@adacore.com>
On 11/12/2012 06:07 PM, Joel Brobecker wrote:
>> 1) is a little bit more tricky because safe_strerror is declared in utils.h
>> header,
>> but implemented in two files:
>> posix-hdep.c and mingw-hdep.c
>>
>> Should I extract the declaration into a
>> gdb/common/gdb_strerror.h
>> and extract the two functions
>> into gdb/common/posix-strerror.c and gdb/common/mingw-strerror.c?
>
> This sounds good to me. There is the option of putting all
> implementation into one single file, the way we do for some
> of our code, but I don't think it would be particularly simpler
> to do that way, since the current code has it separated in 2 files.
>
> In terms of the name, perhaps we should make it more explicit that
> this is not strerror, but safe_strerror?
strerror sounds like something gnulib might have a replacement for
too. Then we could get rid of safe_strerror, and just use strerror
everywhere.
--
Pedro Alves