This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: patches for mac support
On Jun 27, 2011, at 10:59 AM, ext Tristan Gingold wrote:
>
> On Jun 26, 2011, at 2:22 AM, <fawzi.mohamed@nokia.com> <fawzi.mohamed@nokia.com> wrote:
>
>> On Friday, June 24, 2011 at 11:38 AM Tristan Gingold [gingold@adacore.com] wrote:
>>
>> On Jun 23, 2011, at 10:07 PM, Fawzi Mohamed wrote:
>>
>>> Mohamed,
>>>
>>> First, thank you for this work.
>>
>> you are welcome
>>
>>>> I have worked on bug http://sourceware.org/bugzilla/show_bug.cgi?id=11488 .
>>>> Now I think that I have reached to bottom of it, and I have a set of clean patches that could use a review.
>>>>
>>>> Apple gdb simply ignores the eh_frame sections for the libraries without embedded dwarf info, not using eh information (which was the first patch that I submitted) but I find that one should be able to use them, so I looked further and found the "correct" fix.
>>>> As the path to it was a bit convoluted I have done a few improvements to pieces of code that did fail as consequence of the original bug.
>>>>
>>>> The "main" fix is
>>>> http://sourceware.org/bugzilla/attachment.cgi?id=5816&action=diff
>>>> which fixes the mmaped read of sections.
>>>
>>> We (AdaCore) has something very similar in our internal tree. I very recently worked on submitting a patch to fix this issue.
>>> The submitted patch was larger as I tried to clean-up this API.
>>
>> great, I don't care the way it goes, as long as it gets fixed...,
>> so I suppose I can skip submitting it, unless yours doesn't get accepted.
>> A pity hat you didn't tell this in the bug, I would have spared some debugging,
>
> I am a lazy guy too :-)
>
>> I am a lazy guy ;)...
>
> Anyway, I have just committed our patch.
>
> BTW, do you (or Nokia) have the FSF copyright assignment ?
yes Nokia has a global copyright assignment to FSF
ciao
Fawzi