This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: readline rebase 5.1->6.2?
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Eli Zaretskii <eliz at gnu dot org>
- Cc: gdb at sourceware dot org, ktietz at redhat dot com, cgf-use-the-mailinglist-please at gnu dot org
- Date: Tue, 22 Mar 2011 20:48:36 +0100
- Subject: Re: readline rebase 5.1->6.2?
- References: <20110322154327.GA8966@host1.jankratochvil.net> <83tyev7z7a.fsf@gnu.org>
On Tue, 22 Mar 2011 20:05:45 +0100, Eli Zaretskii wrote:
> > Just the patches are of the kind of MS-related platforms compatibility:
> > +dnl BEGIN changes for CYGNUS cross-building for Cygwin
> > +#ifdef __MSDOS__
> > +#if defined (__GO32__)
> > +#ifndef __MINGW32__
> > !+#if defined (SIGWINCH)
> > ? (+#if defined (HAVE_GETPWENT))
>
> I'm not sure I understand: are you saying that the local patches we
> have in GDB wrt the original readline 5.1 are those listed above? If
> so, the last two are not about MS platforms.
The patch for SIGWINCH applies for the case when SIGWINCH is not defined
- which happens only on some non-UNIX platforms I guess, I do not know if on
MS platforms.
With HAVE_GETPWENT you are right that patch may be completely unrelated to the
MS platforms.
> Can you show these patches in full?
I do not have anything else than you have. I just used diff on
ftp://ftp.cwru.edu/pub/bash/readline-5.1.tar.gz
vs. src/readline. But one should rather check individual patches
with git annotate / git show etc. and compare them against readline-6.2.
Thanks,
Jan