Re: GDB 6.8.92 available for testing

[Joel Brobecker <brobecker at adacore dot com>]

> 3) gdb.base/shr1.c (wrong format arg type)
> 3) is about an address, but "%p" does not seem to be supported by all
> C lib format implementation, so I don't know if this can be fixed correctly.

We already use %p in a couple of testcase, so let's use it again here.
Best to avoid printing stuff on stdout/stderr when writing a testcase,
as we don't always have access to the inferior output (for instance,
when doing remote debugging), so matching the inferior output in the
testcase won't work in those case.  But we'd have to dig deeper in
the history of this testcase to determine whether removing the printf
would not impact the effectiveness of the testcase.

For now, I vote for a group hug and the use of %p.

> 4) gdb.base/unload.c (format arg not literal)
> 5) gdb.base/watchpoint-solib.c (format arg not literal)  
> 4) and 5) seem more difficult ...

Is that the source of the problem?

        fprintf (stderr, dlerror ());

The following should take care of it:

        fprintf (stderr, "%s", dlerror ())

-- 
Joel