This is the mail archive of the gdb@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Solibs and objfile BFD ownership


On Tue, Aug 04, 2009 at 10:37:24AM -0700, Paul Pluzhnikov wrote:
> On Tue, Aug 4, 2009 at 7:53 AM, Daniel Jacobowitz<drow@false.org> wrote:
> 
> > A comment somewhere about the usage of the usrdata field would be
> > nice. ?I gather that NULL and 1 behave the same?
> 
> Yes. I added comment to gdb_bfd_unref.
> Updated patch attached. Tested on Linux/x86_64 with no new failures.
> 
> Daniel, could you confirm that this fixes the ARM failures?

Yes - looks much better with this patch!

> 2009-08-04  Paul Pluzhnikov  <ppluzhnikov@google.com>
> 
>        * objfiles.h (OBJF_KEEPBFD): Delete.
>        (gdb_bfd_unref): New prototype.
>        * objfiles.c (gdb_bfd_unref): New function.
>        (free_objfile): Call gdb_bfd_unref.
>        * solib.c (free_so): Likewise.
>        (symbol_add_stub): Set refcount.

OK.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]