This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: (len % 1) != 0
On Sun, Feb 17, 2008 at 10:41:36PM +0800, Bin Chen wrote:
> Hi Daniel,
>
> Is it a bug?
Yes. Fixed as below.
--
Daniel Jacobowitz
CodeSourcery
2008-02-17 Daniel Jacobowitz <dan@codesourcery.com>
* server.c (handle_query): Correct length check.
Index: server.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.c,v
retrieving revision 1.64
diff -u -p -r1.64 server.c
--- server.c 14 Feb 2008 16:42:55 -0000 1.64
+++ server.c 17 Feb 2008 15:25:22 -0000
@@ -649,7 +649,7 @@ handle_query (char *own_buf, int packet_
char *mon = malloc (PBUFSIZ);
int len = strlen (own_buf + 6);
- if ((len % 1) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2)
+ if ((len % 2) != 0 || unhexify (mon, own_buf + 6, len / 2) != len / 2)
{
write_enn (own_buf);
free (mon);