This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: MI: "^running" issues
On Sat, Sep 08, 2007 at 12:30:17PM +1200, Nick Roberts wrote:
> > We're in a tricky situation. The developers of async mode were
> > respected contributors - but they're not here any more to explain
> > their work. It doesn't work as-is, so we can't test it. And Nick's
> > patches to bring it into shape require someone who really understands
> > what they're doing to review them. That's not going to be me, since I
> > couldn't figure the patches out when I last tried.
>
> I don't really see much difference between GDB having code that we don't fully
> understand, and installing code that we don't fully understand to use it: in
> both cases we rely on the testsuite. The difference being that, if my changes
> are installed, asynchronous operation will get tested and over time the code
> will improve.
When the code was originally installed, by its authors, they
understood it. By committing it, they declared that it was right
(at the time, in the current context, et cetera). Code that we
don't understand doesn't have that assurance.
I think it's a pretty big difference, but as I said, I am not likely
to review such patches myself since I don't understand them. And I'm
trying to cut back on the time I spent on review over the past few
years. If another maintainer reviews them and has a different
opinion, I'm not going to get in the way.
--
Daniel Jacobowitz
CodeSourcery