This is the mail archive of the
gdb@sourceware.org
mailing list for the GDB project.
Re: PAGE_SIZE Availability Inconsistency
- From: David Miller <davem at davemloft dot net>
- To: anton at samba dot org
- Cc: hpa at zytor dot com, hch at infradead dot org, arjan at infradead dot org, zippel at linux-m68k dot org, dmlb2000 at gmail dot com, linux-kernel at vger dot kernel dot org, gdb at sourceware dot org
- Date: Thu, 08 Mar 2007 13:48:25 -0800 (PST)
- Subject: Re: PAGE_SIZE Availability Inconsistency
- References: <20070308175729.GA7054@kryten> <45F05040.4090602@zytor.com> <20070308214236.GA4154@kryten>
From: Anton Blanchard <anton@samba.org>
Date: Thu, 8 Mar 2007 15:42:36 -0600
> > The easiest way to fix this would be to always park the swap magic at
> > the offset of the smallest page size in use, which is 4K. This is
> > analogous how the offset for the ext2/3 superblock got fixed at 1K --
> > for 1K blocks, it's the second block, but for larger blocks, it's part
> > of the first block. If we fix the offset of the swap magic at 4096
> > minus the offset that's already there, it will always fall in the first
> > page regardless of page size.
>
> Yeah that makes sense. I gave it a go by creating a MIN_PAGE_SIZE
> define, and allowing an architecture to override it if required.
I might be missing something but doesn't this break every
SWAP partition that was created with something other than
MIN_PAGE_SIZE?