Testsuite breakage

[Mark Kettenis <mark dot kettenis at xs4all dot nl>]

Hi Nathan,

I get quite a bit more bogus testsuite output, and I'm pretty certain
it's because of this change:

2007-01-11  Nathan Sidwell  <nathan@codesourcery.com>

        * lib/gdb.exp (gdb_compile_test): New.
        (skip_ada_tests, skip_java_tests): New.
        (gdb_compile): Use gdb_compile_test for f77.
        * lib/ada.exp (gdb_compile_ada): Use gdb_compile_test to record result.
        * lib/java.exp (compile_java_from_source): Remove runtests check,
        use gdb_compile_test to record result.
        * gdb.ada/packed_array.exp, gdb.ada/fixed_points.exp,
        gdb.ada/exec_changed.exp, gdb.ada/start.exp,
        gdb.ada/watch_arg.exp, gdb.ada/null_record.exp,
        gdb.ada/array_return.exp, gdb.ada/arrayidx.exp,
        gdb.mi/mi-var-child-f.exp, gdb.fortran/types.exp,
        gdb.fortran/array-element.exp, gdb.fortran/subarray.exp,
        gdb.fortran/derived-type.exp, gdb.fortran/exprs.exp,
        gdb.java/jmisc.exp, gdb.java/jprint.exp,
        gdb.java/jv-print.exp, gdb.java/jmain.exp: Add language skip,
        adjust gdb_compile invocations.

Here are some selected diffs with an earlier testrun:

--- gdb.sum.1	Mon Jan  1 17:25:35 2007
+++ gdb.sum	Thu Jan 11 23:18:34 2007
@@ -1,4 +1,4 @@
-Test Run By kettenis on Mon Jan  1 17:05:44 2007
+Test Run By kettenis on Thu Jan 11 22:58:25 2007
 Native configuration is powerpc-unknown-openbsd3.9
 
 		=== gdb tests ===
@@ -8,21 +8,23 @@
 
 Running target unix
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/array_return.exp ...
-UNSUPPORTED: gdb.ada/array_return.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/array_return.exp: compilation p.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/arrayidx.exp ...
-UNSUPPORTED: gdb.ada/arrayidx.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/arrayidx.exp: compilation p.adb
+Running ../../../../src/gdb/gdb/testsuite/gdb.ada/catch_ex.exp ...
+UNSUPPORTED: gdb.ada/catch_ex.exp: compilation foo.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/exec_changed.exp ...
-UNSUPPORTED: gdb.ada/exec_changed.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/exec_changed.exp: compilation first.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/fixed_points.exp ...
-UNSUPPORTED: gdb.ada/fixed_points.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/fixed_points.exp: compilation fixed_points.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/null_record.exp ...
-UNSUPPORTED: gdb.ada/null_record.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/null_record.exp: compilation null_record.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/packed_array.exp ...
-UNSUPPORTED: gdb.ada/packed_array.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/packed_array.exp: compilation pa.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/start.exp ...
-UNSUPPORTED: gdb.ada/start.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/start.exp: compilation dummy.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.ada/watch_arg.exp ...
-UNSUPPORTED: gdb.ada/watch_arg.exp: Ada compilation failed: default_target_compile: Can't find gnatmake.
+UNSUPPORTED: gdb.ada/watch_arg.exp: compilation watch.adb
 Running ../../../../src/gdb/gdb/testsuite/gdb.arch/alpha-step.exp ...
 Running ../../../../src/gdb/gdb/testsuite/gdb.arch/altivec-abi.exp ...
 gdb compile failed, ../../../../src/gdb/gdb/testsuite/gdb.arch/altivec-abi.c: In function `vec_func':


I think the old UNSUPPORTED output was more useful.



@@ -9043,13 +9059,14 @@
 PASS: gdb.dwarf2/mac-fileno.exp: list func_cu1
 PASS: gdb.dwarf2/mac-fileno.exp: ptype func_cu1
 Running ../../../../src/gdb/gdb/testsuite/gdb.fortran/array-element.exp ...
+PASS: gdb.fortran/array-element.exp: compilation array-element.f
 PASS: gdb.fortran/array-element.exp: breakpoint at continue
 PASS: gdb.fortran/array-element.exp: continue to breakpoint
 PASS: gdb.fortran/array-element.exp: print the first element of array a
 PASS: gdb.fortran/array-element.exp: continue to breakpoint once again
 PASS: gdb.fortran/array-element.exp: print the second element of array a
 Running ../../../../src/gdb/gdb/testsuite/gdb.fortran/derived-type.exp ...
-UNTESTED: gdb.fortran/derived-type.exp: Couldn't compile derived-type.f90
+FAIL: gdb.fortran/derived-type.exp: compilation derived-type.f90

Here we went from UNTESTED to FAIL.  I guess g77 doesn't understand
FORTRAN 90, so this really should remain an UNTESTED.

@@ -9376,11 +9396,41 @@
 Running ../../../../src/gdb/gdb/testsuite/gdb.hp/gdb.objdbg/objdbg03.exp ...
 Running ../../../../src/gdb/gdb/testsuite/gdb.hp/gdb.objdbg/objdbg04.exp ...
 Running ../../../../src/gdb/gdb/testsuite/gdb.java/jmain.exp ...
-UNTESTED: gdb.java/jmain.exp: Couldn't compile ../../../../src/gdb/gdb/testsuite/gdb.java/jmain.java
+ERROR: tcl error sourcing ../../../../src/gdb/gdb/testsuite/gdb.java/jmain.exp.
+ERROR: wrong # args: should be "target_compile source destfile type options"
+    while executing
+"target_compile $srcfile ${binfile} ${binfile} executable $args"
+    (procedure "compile_java_from_source" line 13)
+    invoked from within
+"compile_java_from_source ${srcfile} ${binfile} "-g""
+    (file "../../../../src/gdb/gdb/testsuite/gdb.java/jmain.exp" line 1)
+    ("uplevel" body line 1)
+    invoked from within
+"catch "uplevel #0 source $test_file_name""
 Running ../../../../src/gdb/gdb/testsuite/gdb.java/jmisc.exp ...
-UNTESTED: gdb.java/jmisc.exp: Couldn't compile ../../../../src/gdb/gdb/testsuite/gdb.java/jmisc.java
+ERROR: tcl error sourcing ../../../../src/gdb/gdb/testsuite/gdb.java/jmisc.exp.
+ERROR: wrong # args: should be "target_compile source destfile type options"
+    while executing
+"target_compile $srcfile ${binfile} ${binfile} executable $args"
+    (procedure "compile_java_from_source" line 13)
+    invoked from within
+"compile_java_from_source ${srcfile} ${binfile} "-g""
+    (file "../../../../src/gdb/gdb/testsuite/gdb.java/jmisc.exp" line 1)
+    ("uplevel" body line 1)
+    invoked from within
+"catch "uplevel #0 source $test_file_name""
 Running ../../../../src/gdb/gdb/testsuite/gdb.java/jprint.exp ...
-UNTESTED: gdb.java/jprint.exp: Couldn't compile ../../../../src/gdb/gdb/testsuite/gdb.java/jprint.java
+ERROR: tcl error sourcing ../../../../src/gdb/gdb/testsuite/gdb.java/jprint.exp.
+ERROR: wrong # args: should be "target_compile source destfile type options"
+    while executing
+"target_compile $srcfile ${binfile} ${binfile} executable $args"
+    (procedure "compile_java_from_source" line 13)
+    invoked from within
+"compile_java_from_source ${srcfile} ${binfile} "-g""
+    (file "../../../../src/gdb/gdb/testsuite/gdb.java/jprint.exp" line 1)
+    ("uplevel" body line 1)
+    invoked from within
+"catch "uplevel #0 source $test_file_name""


No Java on my system, so again these should remain UNTESTED.  They
should defenitely not result in tcl parsing errors.


 Running ../../../../src/gdb/gdb/testsuite/gdb.threads/staticthreads.exp ...
-PASS: gdb.threads/staticthreads.exp: successfully compiled posix threads test case
+ERROR: no fileid for martinu
+UNRESOLVED: gdb.threads/staticthreads.exp: successfully compiled posix threads test case


I don't understand what's happening here, but it probably has
something to do with the fact that the first compilation (which uses
-lpthreads) fails, but the "retry" with -lpthread succeeds.

Can you look into this?

Mark