This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: [RFC] Register sets
- From: Mark Kettenis <kettenis at chello dot nl>
- To: jimb at redhat dot com
- Cc: drow at mvista dot com, gdb at sources dot redhat dot com
- Date: Sat, 6 Sep 2003 16:17:48 +0200 (CEST)
- Subject: Re: [RFC] Register sets
- References: <200308232249.h7NMnvhh090154@elgar.kettenis.dyndns.org><20030824164347.GA17520@nevyn.them.org><200308252234.h7PMYqFu001245@elgar.kettenis.dyndns.org><3F4B8173.1000302@redhat.com> <20030826165547.GA22836@nevyn.them.org><86he3xrkjb.fsf@elgar.kettenis.dyndns.org><20030904125514.GA2577@nevyn.them.org> <vt2oexyzswx.fsf@zenia.home>
From: Jim Blandy <jimb@redhat.com>
Date: 05 Sep 2003 19:01:34 -0500
Daniel Jacobowitz <drow@mvista.com> writes:
> struct regset
> {
> void (*supply_regset)(struct regcache *, const void *, size_t, int);
> void (*read_regset)(struct regcache *, void *, size_t, int);
> };
If you want to allow people to define regset formats via the CLI, it
seems to me you probably want some kind of closure argument in there,
like this:
struct regset
{
/* Always pass this to the supply_regset and read_regset
functions below as their first argument. */
void *closure;
void (*supply_regset)(void *closure,
struct regcache *, const void *, size_t, int);
void (*read_regset)(void *closure,
struct regcache *, void *, size_t, int);
};
This gives you the hook you need to have a single function for all
CLI-defined regsets, interpreting the layout the user supplies to the
CLI command.
Actually I need this closure argument for the corefile regset stuff
too. For the i386 I have a single supply_regset function for all the
different "gregsets", and I define a table with offsets that defines
rhe proper mapping in `struct gdbarch_tdep'. I could get at that
mapping since I was passing the architecture in, but that's just a
special case of the closure argument you propose.
Mark