This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: found gdbarch solib issue


> Shouldn't it be returning arch_info anyway?  Why isn't it?  Is it
> returning handler->arch_info?

That's what was puzzling me.  I was looking through the linked list of 10
million mips arches and thinking what the odds were of compatible ever
equalling the handler arch_info.  Seems to me that the return value might be
useful in some circumstances but in this case it should be a boolean, "am I
compatible or not?"

> > -      compatible = arch_info->compatible (arch_info,
handler->arch_info);
> > -      if (compatible == handler->arch_info)
> > +      if(arch_info->compatible (arch_info, handler->arch_info))

cheers,

Kris


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]