event-loop.c changes

[Elena Zannoni <ezannoni at redhat dot com>]

Jim, I am looking at some of the changes in event-loop.c (from Keith's
branch).

I am not sure about a couple of things:

This comment:

void
gdb_setup_readline (void)
{
  /* This function is a noop for the async case.  The assumption is that
     the async setup is ALL done in gdb_init, and we would only mess it up
     here.  The async stuff should really go away over time. */

  if (event_loop_p)
    {
[...]
    }
}

You meant 'sync' instead of 'async'?


The creation of these:
      gdb_stdout = stdio_fileopen (stdout);
      gdb_stderr = stdio_fileopen (stderr);
      gdb_stdlog = gdb_stderr;  /* for moment */
      gdb_stdtarg = gdb_stderr; /* for moment */

Is done in main.c, then again here, in gdb-setup-readline().
But a comment in gdb_disable_readline suggests that they really
shouldn't be created here at all.
     /* FIXME - It is too heavyweight to delete and remake these
         every time you run an interpreter that needs readline.
         It is probably better to have the interpreters cache these,
         which in turn means that this needs to be moved into interpreter
         specific code. */


Thanks
Elena