This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: [patch] generic simd support
- From: Richard Henderson <rth at redhat dot com>
- To: Aldy Hernandez <aldyh at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, gcc at gcc dot gnu dot org, gdb at sources dot redhat dot com
- Date: Thu, 30 May 2002 15:42:56 -0700
- Subject: Re: [patch] generic simd support
- References: <20020522004429.GA26426@redhat.com>
On Wed, May 22, 2002 at 10:44:29AM +1000, Aldy Hernandez wrote:
> ! error ("architecture does not support `%s' and I am unable to emulate it",
Better just "unable to emulate %s".
> + /* Open-code the vector operations if we have no hardware support
> + for them. */
This function is way too big already. Please move your code
out into a subroutine.
> ! /* ?? I'm not sure whether this is right. This is the path we
> ! take on synthetic complex types because the target is a
> ! CONCAT of register, not a register per se. However, for
> ! synthetic vector types, we don't have a CONCAT, but an
> ! entire pseudo. Get out here to avoid removing needed
> ! instructions.
> ! ?? */
> ! || vector_mode_valid_p (GET_MODE (target))
> ! || reload_in_progress)
Maybe you should just avoid the no-conflict block entirely?
Otherwise it looks reasonable.
r~