This is the mail archive of the gdb@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: ARM floating point regs regression


> I don't know how but almost all the lines initializing TYPE_FLOATFORMAT 
>> were lost.
>> 


(try the attached, if it works, I'll add a few extra assertions so that the coredump can't occure).


> 
> 
> Hmm, I think I understand why it is failing.
> 
> Although the FPA has an extended float format (which is used for stacking 
> regs across function calls), this type isn't used for "long double".  So I 
> suspect the initialization code in gdbtypes.c is not setting it up 
> correctly for this case.


It shouldn't have got that far.  the FPA extended float should have 
TYPE_FLOATFORMAT set so that GDB can correctly and directly manipulate 
the floating point value - no conversions being needed.  The above 
should stop this.  Only as a last resort should gdb be trying to map a 
floating point type onto one of float, double or long double.

BTW, it didn't work this way in the past.  In the ``good old days'' GDB 
would convert hardware floating point formats into float, double, or 
long double (no matter how lossy that process was).

Andrew
2002-01-22  Andrew Cagney  <ac131313@redhat.com>

	* gdbtypes.c (_initialize_gdbtypes): Initialize TYPE_FLOATFORMAT
	for builtin_type_ieee_single_little, builtin_type_ieee_double_big,
	builtin_type_ieee_double_little,
	builtin_type_ieee_double_littlebyte_bigword,
	builtin_type_m68881_ext, builtin_type_i960_ext,
	builtin_type_m88110_ext, builtin_type_m88110_harris_ext,
	builtin_type_arm_ext_big, builtin_type_arm_ext_littlebyte_bigword,
	builtin_type_ia64_spill_big, builtin_type_ia64_spill_little and
	builtin_type_ia64_quad_big, builtin_type_ia64_quad_little.

Index: gdbtypes.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbtypes.c,v
retrieving revision 1.37
diff -p -r1.37 gdbtypes.c
*** gdbtypes.c	2002/01/20 19:42:04	1.37
--- gdbtypes.c	2002/01/22 17:54:14
*************** _initialize_gdbtypes (void)
*** 3328,3342 ****
--- 3328,3346 ----
    builtin_type_ieee_single_little =
      init_type (TYPE_CODE_FLT, floatformat_ieee_single_little.totalsize / 8,
  	       0, "builtin_type_ieee_single_little", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ieee_single_little) = &floatformat_ieee_single_little;
    builtin_type_ieee_double_big =
      init_type (TYPE_CODE_FLT, floatformat_ieee_double_big.totalsize / 8,
  	       0, "builtin_type_ieee_double_big", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ieee_double_big) = &floatformat_ieee_double_big;
    builtin_type_ieee_double_little =
      init_type (TYPE_CODE_FLT, floatformat_ieee_double_little.totalsize / 8,
  	       0, "builtin_type_ieee_double_little", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ieee_double_little) = &floatformat_ieee_double_little;
    builtin_type_ieee_double_littlebyte_bigword =
      init_type (TYPE_CODE_FLT, floatformat_ieee_double_littlebyte_bigword.totalsize / 8,
  	       0, "builtin_type_ieee_double_littlebyte_bigword", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ieee_double_littlebyte_bigword) = &floatformat_ieee_double_littlebyte_bigword;
    builtin_type_i387_ext =
      init_type (TYPE_CODE_FLT, floatformat_i387_ext.totalsize / 8,
  	       0, "builtin_type_i387_ext", NULL);
*************** _initialize_gdbtypes (void)
*** 3344,3376 ****
--- 3348,3390 ----
    builtin_type_m68881_ext =
      init_type (TYPE_CODE_FLT, floatformat_m68881_ext.totalsize / 8,
  	       0, "builtin_type_m68881_ext", NULL);
+   TYPE_FLOATFORMAT (builtin_type_m68881_ext) = &floatformat_m68881_ext;
    builtin_type_i960_ext =
      init_type (TYPE_CODE_FLT, floatformat_i960_ext.totalsize / 8,
  	       0, "builtin_type_i960_ext", NULL);
+   TYPE_FLOATFORMAT (builtin_type_i960_ext) = &floatformat_i960_ext;
    builtin_type_m88110_ext =
      init_type (TYPE_CODE_FLT, floatformat_m88110_ext.totalsize / 8,
  	       0, "builtin_type_m88110_ext", NULL);
+   TYPE_FLOATFORMAT (builtin_type_m88110_ext) = &floatformat_m88110_ext;
    builtin_type_m88110_harris_ext =
      init_type (TYPE_CODE_FLT, floatformat_m88110_harris_ext.totalsize / 8,
  	       0, "builtin_type_m88110_harris_ext", NULL);
+   TYPE_FLOATFORMAT (builtin_type_m88110_harris_ext) = &floatformat_m88110_harris_ext;
    builtin_type_arm_ext_big =
      init_type (TYPE_CODE_FLT, floatformat_arm_ext_big.totalsize / 8,
  	       0, "builtin_type_arm_ext_big", NULL);
+   TYPE_FLOATFORMAT (builtin_type_arm_ext_big) = &floatformat_arm_ext_big;
    builtin_type_arm_ext_littlebyte_bigword =
      init_type (TYPE_CODE_FLT, floatformat_arm_ext_littlebyte_bigword.totalsize / 8,
  	       0, "builtin_type_arm_ext_littlebyte_bigword", NULL);
+   TYPE_FLOATFORMAT (builtin_type_arm_ext_littlebyte_bigword) = &floatformat_arm_ext_littlebyte_bigword;
    builtin_type_ia64_spill_big =
      init_type (TYPE_CODE_FLT, floatformat_ia64_spill_big.totalsize / 8,
  	       0, "builtin_type_ia64_spill_big", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ia64_spill_big) = &floatformat_ia64_spill_big;
    builtin_type_ia64_spill_little =
      init_type (TYPE_CODE_FLT, floatformat_ia64_spill_little.totalsize / 8,
  	       0, "builtin_type_ia64_spill_little", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ia64_spill_little) = &floatformat_ia64_spill_little;
    builtin_type_ia64_quad_big =
      init_type (TYPE_CODE_FLT, floatformat_ia64_quad_big.totalsize / 8,
  	       0, "builtin_type_ia64_quad_big", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ia64_quad_big) = &floatformat_ia64_quad_big;
    builtin_type_ia64_quad_little =
      init_type (TYPE_CODE_FLT, floatformat_ia64_quad_little.totalsize / 8,
  	       0, "builtin_type_ia64_quad_little", NULL);
+   TYPE_FLOATFORMAT (builtin_type_ia64_quad_little) = &floatformat_ia64_quad_little;
  
    add_show_from_set (
  		     add_set_cmd ("overload", no_class, var_zinteger, (char *) &overload_debug,

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]