This is the mail archive of the
gdb@sources.redhat.com
mailing list for the GDB project.
Re: RFC: gdbglobals.[ch]
- To: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Subject: Re: RFC: gdbglobals.[ch]
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Wed, 13 Dec 2000 14:37:26 +0000
- CC: gdb at sources dot redhat dot com
- Organization: Red Hat Canada Ltd. - Toronto
- References: <3A368138.A7360C4A@cygnus.com> <200012131141.GAA14558@indy.delorie.com>
Thank you for your comments Eli.
Eli Zaretskii wrote:
>
> > Date: Tue, 12 Dec 2000 14:49:12 -0500
> > From: Fernando Nasser <fnasser@cygnus.com>
> >
> > enum var_types
> > {
>
> Why is a `double' missing from this enum?
>
Because I just used whatever we currently have in commands.h,
which implies we do not have any doubles yet settable with
set/show commands.
I had added a "(initially)" in my draft but I somehow took it off.
> > /* Obtain the current value of a global. */
> >
> > extern gdb_global_rc
> > gdb_global_get_value (gdb_global_handle global, char **cur_val);
>
> Shouldn't the last argument be a "void **"?
>
I initially defined it as a void ** but then I realized out set/show
facility and the commands.h stuff use char **.
To minimize the conversion effort I thought of keeping it like it is now.
I wonder if this was not done this way due to some compatibility problem.
Maybe the reason no longer exists anyway.
> > /* Set a new value in a global and notify consumers. */
> >
> > extern gdb_global_rc
> > gdb_global_set_value (, char *new_val);
>
> Something (a handle?) is missing here.
Ops! Thanks. You are right, it is the handle.
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9