This is the mail archive of the
gdb-testers@sourceware.org
mailing list for the GDB project.
[binutils-gdb] Error out immediatly when using if command without args in command list
- From: sergiodj+buildbot at sergiodj dot net
- To: gdb-testers at sourceware dot org
- Date: Mon, 04 Sep 2017 16:13:13 -0400
- Subject: [binutils-gdb] Error out immediatly when using if command without args in command list
- Authentication-results: sourceware.org; auth=none
*** TEST RESULTS FOR COMMIT 80a65e9b8fbc93d4a7548ac17b8094ced23f66a7 ***
Author: Simon Marchi <simon.marchi@ericsson.com>
Branch: master
Commit: 80a65e9b8fbc93d4a7548ac17b8094ced23f66a7
Error out immediatly when using if command without args in command list
When using "if" (or while) without args directly on gdb's command line,
you get this:
(gdb) if
if/while commands require arguments
When doing the same when entering a command list, you only get an error
when the command is executed, when parse_exp_in_context_1 fails to
evaluate the expression.
(gdb) define foo
Type commands for definition of "foo".
End with a line saying just "end".
>if
>end
>end
(gdb) foo
Argument required (expression to compute).
I think it would make more sense to error out when inputting the command
list directly:
(gdb) define foo
Type commands for definition of "foo".
End with a line saying just "end".
>if
if/while commands require arguments.
The only required change is to check whether args is an empty string in
build_command_line.
gdb/ChangeLog:
* cli/cli-script.c (build_command_line): For if/while commands,
check whether args is empty.
gdb/testsuite/ChangeLog:
* gdb.base/commands.exp: Call new procedure.
(define_if_without_arg_test): New procedure.